From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] rtc: pfc8563: fix uninitialized variable warning
Date: Thu, 14 May 2015 23:50:47 +0200 [thread overview]
Message-ID: <20150514215047.GE3338@piout.net> (raw)
In-Reply-To: <2293546.ekQV1ek12O@wuerfel>
Hi Andrew,
On 12/05/2015 at 23:27:02 +0200, Arnd Bergmann wrote :
> Gcc is unable to prove that alm_pending is always initialized
> when it is used, so it prints a harmless warning:
>
> drivers/rtc/rtc-pcf8563.c: In function 'pcf8563_probe':
> drivers/rtc/rtc-pcf8563.c:449:5: warning: 'alm_pending' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> This uses the same conditional expression that is used inside of
> the pcf8563_get_alarm_mode() function, to help gcc figure it out
> and shut up that warning, and make the ARM defconfigs build again
> with no warnings.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a45d528aab8b ("rtc: pcf8563: clear expired alarm at boot time")
>
Can you send that fix to Linus for the next 4.1 rc?
You can add my
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I hope that will be the last one :)
Thanks!
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-14 21:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:27 [PATCH] rtc: pfc8563: fix uninitialized variable warning Arnd Bergmann
2015-05-14 21:50 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514215047.GE3338@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).