From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] ARM: correct secondary_startup_arm mode
Date: Sat, 16 May 2015 22:19:00 +0100 [thread overview]
Message-ID: <20150516211900.GP2067@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CABuKBeJwWR1+0mJkStJFNMeOsESKJCH4T1w5HTyUv5q=KAN7EA@mail.gmail.com>
On Sat, May 16, 2015 at 11:08:36AM +0200, Matthias Brugger wrote:
> 2015-05-16 9:58 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> > secondary_startup_arm is used as ARM mode secondary start up function
> > when ther kernel is compiled in THUMB mode, however the label itself
> > is still in .thumb mode. readelf shows:
> >
> > 160979: c020a581 120 FUNC GLOBAL DEFAULT 2 secondary_startup_arm
> >
> > Make sure the label is in ARM mode as well.
> >
> > Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> > ---
> > arch/arm/kernel/head.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> > index 3637973..58ee8a2 100644
> > --- a/arch/arm/kernel/head.S
> > +++ b/arch/arm/kernel/head.S
> > @@ -346,8 +346,8 @@ __turn_mmu_on_loc:
> >
> > #if defined(CONFIG_SMP)
> > .text
> > -ENTRY(secondary_startup_arm)
> > .arm
> > +ENTRY(secondary_startup_arm)
> > THUMB( adr r9, BSYM(1f) ) @ Kernel is entered in ARM.
> > THUMB( bx r9 ) @ If this is a Thumb-2 kernel,
> > THUMB( .thumb ) @ switch to Thumb now.
>
> This fixes and issue we had with SMP on mt6589.
>
> Tested-by: Matthias Brugger <matthias.bgg@gmail.com>
Please ensure that this patch ends up in the patch system so it doesn't
get forgotten about, thanks.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-05-16 21:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 7:58 [PATCH v2 0/9] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 1/9] ARM: correct secondary_startup_arm mode Yingjoe Chen
2015-05-16 9:08 ` Matthias Brugger
2015-05-16 21:19 ` Russell King - ARM Linux [this message]
2015-05-16 7:58 ` [PATCH v2 2/9] ARM: add secondary_startup_arm prototype in header file Yingjoe Chen
2015-05-16 9:02 ` Matthias Brugger
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-18 8:56 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 3/9] clocksource: mediatek: do not enable GPT_CLK_EVT when setup Yingjoe Chen
2015-05-20 10:22 ` Matthias Brugger
2015-05-16 7:58 ` [PATCH v2 4/9] clocksource: mediatek: Use GPT as sched clock source Yingjoe Chen
2015-05-20 11:02 ` Matthias Brugger
2015-05-20 14:05 ` Yingjoe Chen
2015-05-20 15:00 ` Matthias Brugger
2015-05-20 18:37 ` Stephen Boyd
2015-07-03 13:48 ` Daniel Kurtz
2015-07-03 15:51 ` Matthias Brugger
2015-07-11 10:32 ` Yingjoe Chen
2015-08-03 15:51 ` Daniel Lezcano
2015-05-16 7:58 ` [PATCH v2 5/9] ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-05-19 19:51 ` Stephen Boyd
2015-05-20 8:43 ` Matthias Brugger
2015-05-20 8:46 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 6/9] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 7/9] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 8/9] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 9/9] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150516211900.GP2067@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).