From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9] crypto: Add Allwinner Security System crypto accelerator
Date: Sun, 17 May 2015 09:45:53 +0200 [thread overview]
Message-ID: <20150517094553.7fd8d8a0@bbrezillon> (raw)
In-Reply-To: <1431608341-10936-1-git-send-email-clabbe.montjoie@gmail.com>
Hello Corentin,
On Thu, 14 May 2015 14:58:57 +0200
LABBE Corentin <clabbe.montjoie@gmail.com> wrote:
>
> Hello
>
> This is the driver for the Security System included in Allwinner SoC A20.
> The Security System (SS for short) is a hardware cryptographic accelerator that
> support AES/MD5/SHA1/DES/3DES/PRNG algorithms.
> It could be found on others Allwinner SoC:
> - A10, A10s, A13, A31 and A33 manual give the same datasheet for SS than A20
> - A23 speak about a security system but without precisions
> - A80 and A83T datasheet speak about a security system with more functions
> (SHA224/SHA256/RSA/CRC), they will be supported in a separate driver
> But I do not have access on any of those hardware, tests are welcome.
>
Maybe this is just a nitpick, but I would reverse the ordering of
patches in this series. The biggest inconsistency is the fact that
you're adding yourself as a maintainer of something that does not even
exist.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-17 7:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 12:58 [PATCH v9] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-14 12:58 ` [PATCH v9 1/4] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2015-05-15 7:31 ` Maxime Ripard
2015-05-23 12:08 ` Corentin LABBE
2015-05-14 12:58 ` [PATCH v9 2/4] ARM: sun4i: dt: Add DT bindings documentation for SUN4I Security System LABBE Corentin
2015-05-14 12:59 ` [PATCH v9 3/4] MAINTAINERS: Add myself as maintainer of Allwinner " LABBE Corentin
2015-05-14 12:59 ` [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-15 6:49 ` Herbert Xu
2015-05-23 12:18 ` [linux-sunxi] " Corentin LABBE
2015-05-24 3:30 ` Herbert Xu
2015-05-15 6:52 ` Herbert Xu
2015-05-16 18:09 ` [linux-sunxi] " Corentin LABBE
2015-05-17 1:32 ` Herbert Xu
2015-05-17 8:45 ` Boris Brezillon
2015-05-17 10:34 ` Herbert Xu
2015-05-17 10:48 ` Boris Brezillon
2015-05-18 0:41 ` Herbert Xu
2015-05-18 7:24 ` Boris Brezillon
2015-05-18 8:33 ` Herbert Xu
2015-05-23 13:12 ` Corentin LABBE
2015-05-23 14:35 ` Boris Brezillon
2015-05-24 3:32 ` Herbert Xu
2015-05-24 8:04 ` [linux-sunxi] " Corentin LABBE
2015-05-24 8:12 ` Herbert Xu
2015-06-03 19:06 ` Corentin LABBE
2015-05-17 7:45 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150517094553.7fd8d8a0@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).