From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller
Date: Mon, 18 May 2015 19:52:30 -0400 (EDT) [thread overview]
Message-ID: <20150518.195230.2247842502863025488.davem@davemloft.net> (raw)
In-Reply-To: <555A5F1E.1010509@caviumnetworks.com>
From: David Daney <ddaney@caviumnetworks.com>
Date: Mon, 18 May 2015 14:52:30 -0700
> As I see it there are two options:
>
> 1) Keep the writeq_relaxed()/readq_relaxed(), but add a comment about
> why they are safe.
>
> 2) Change the patch so that we are using writeq()/readq() and suffer a
> decrease in performance.
I want a detailed comment added, so #1 would be my choice.
There are more than one set of register accessors, so make sure you
annotate them all.
Thanks.
prev parent reply other threads:[~2015-05-18 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1431747401-20847-1-git-send-email-aleksey.makarov@auriga.com>
[not found] ` <1431747401-20847-3-git-send-email-aleksey.makarov@auriga.com>
2015-05-18 8:46 ` [PATCH net-next v3 2/2] net: Adding support for Cavium ThunderX network controller Paul Bolle
2015-05-18 20:09 ` David Miller
2015-05-18 21:52 ` David Daney
2015-05-18 23:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518.195230.2247842502863025488.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox