public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/12] ARM: migrate to common PSCI client code
Date: Mon, 18 May 2015 10:46:30 +0100	[thread overview]
Message-ID: <20150518094630.GB3551@leverpostej> (raw)
In-Reply-To: <CAJ5Y-eYYUr6xUTGRvr_K-Cj0dPXhickk01o9oWQVJC0EXEHLNA@mail.gmail.com>

> >> +int psci_cpu_disable(unsigned int cpu)
> >> +{
> >> +       /* Fail early if we don't have CPU_OFF support */
> >> +       if (!psci_ops.cpu_off)
> >> +               return 0;
> >> +
> >> +       /* Trusted OS will deny CPU_OFF */
> >> +       if (psci_tos_resident_on(cpu))
> >> +               return 0;
> >> +
> >
> > Same question here. Seems like if MIGRATE_INFO_TYPE = 2 ( TOS is
> > present or does not require migration), you should be able to call
> > CPU_OFF. Otherwise the patch looks fine to me.
> 
> err. Make that TOS is not present.

In the cases where migration is not required, resident_cpu == -1, and
psci_tos_resident_on(cpu) will return false for any valid CPU. So I
don't see that we would deny migration here.

What am I missing?

Thanks,
Mark.

  reply	other threads:[~2015-05-18  9:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-08 11:36 [PATCH 00/12] arm/arm64: Unify PSCI client support Mark Rutland
2015-05-08 11:36 ` [PATCH 01/12] arm/arm64: kvm: add missing PSCI include Mark Rutland
2015-05-12 14:07   ` Christoffer Dall
2015-05-08 11:36 ` [PATCH 02/12] arm64: smp_plat: add get_logical_index Mark Rutland
2015-05-08 11:36 ` [PATCH 03/12] arm64: smp: consistently use error codes Mark Rutland
2015-05-08 11:36 ` [PATCH 04/12] arm64: psci: remove unnecessary id indirection Mark Rutland
2015-05-08 11:36 ` [PATCH 05/12] arm64: psci: support unsigned return values Mark Rutland
2015-05-11 12:25   ` Lorenzo Pieralisi
2015-05-11 12:39     ` Mark Rutland
2015-05-08 11:36 ` [PATCH 06/12] arm64: psci: account for Trusted OS instances Mark Rutland
2015-05-13 14:22   ` Lorenzo Pieralisi
2015-05-18 10:04     ` Mark Rutland
2015-05-15 15:06   ` Ashwin Chaugule
2015-05-18  9:24     ` Mark Rutland
2015-05-08 11:36 ` [PATCH 07/12] arm64: psci: kill psci_power_state Mark Rutland
2015-05-11 15:32   ` Lorenzo Pieralisi
2015-05-08 11:36 ` [PATCH 08/12] arm64: psci: remove ACPI coupling Mark Rutland
2015-05-15 15:10   ` Ashwin Chaugule
2015-05-08 11:36 ` [PATCH 09/12] arm64: psci: factor invocation code to drivers Mark Rutland
2015-05-13  9:40   ` Mark Rutland
2015-05-08 11:36 ` [PATCH 10/12] drivers: psci: support native SMC{32,64} calls Mark Rutland
2015-05-08 11:36 ` [PATCH 11/12] ARM: migrate to common PSCI client code Mark Rutland
2015-05-15 15:41   ` Ashwin Chaugule
2015-05-15 15:43     ` Ashwin Chaugule
2015-05-18  9:46       ` Mark Rutland [this message]
2015-05-18 19:14         ` Ashwin Chaugule
2015-05-26 12:59           ` Mark Rutland
2015-05-08 11:36 ` [PATCH 12/12] MAINTAINERS: add PSCI entry Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150518094630.GB3551@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox