linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: bparrot@ti.com (Benoit Parrot)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [media] ov2659: add v4l2_subdev dependency
Date: Tue, 19 May 2015 11:20:03 -0500	[thread overview]
Message-ID: <20150519162002.GE8123@ti.com> (raw)
In-Reply-To: <6092911.yr0lA5IaG4@wuerfel>

Thanks, for the patch.

Acked-by: Benoit Parrot <bparrot@ti.com>

Arnd Bergmann <arnd@arndb.de> wrote on Tue [2015-May-19 14:39:12 +0200]:
> The newly added ov2659 driver uses the v4l2 subdev API, but
> can be enabled even when that API is not part of the kernel,
> resulting in this build error:
> 
> media/i2c/ov2659.c: In function 'ov2659_get_fmt':
> media/i2c/ov2659.c:1054:8: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
> media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> media/i2c/ov2659.c: In function 'ov2659_set_fmt':
> media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> media/i2c/ov2659.c: In function 'ov2659_open':
> media/i2c/ov2659.c:1264:38: error: 'struct v4l2_subdev_fh' has no member named 'pad'
> 
> This adds an explicit dependency, like all the other drivers have.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c4c0283ab3c ("[media] media: i2c: add support for omnivision's ov2659 sensor")
> 
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 6f30ea76151a..db01ed84918f 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -469,7 +469,7 @@ config VIDEO_SMIAPP_PLL
>  config VIDEO_OV2659
>  	tristate "OmniVision OV2659 sensor support"
>  	depends on VIDEO_V4L2 && I2C
> -	depends on MEDIA_CAMERA_SUPPORT
> +	depends on MEDIA_CAMERA_SUPPORT && VIDEO_V4L2_SUBDEV_API
>  	---help---
>  	  This is a Video4Linux2 sensor-level driver for the OmniVision
>  	  OV2659 camera.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-05-19 16:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 12:39 [PATCH] [media] ov2659: add v4l2_subdev dependency Arnd Bergmann
2015-05-19 16:20 ` Benoit Parrot [this message]
2015-05-19 16:46 ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150519162002.GE8123@ti.com \
    --to=bparrot@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).