From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [V4 PATCH 1/6] ACPI / scan: Parse _CCA and setup device coherency
Date: Wed, 20 May 2015 11:01:22 +0100 [thread overview]
Message-ID: <20150520100122.GD25313@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <1431724994-21601-2-git-send-email-Suravee.Suthikulpanit@amd.com>
On Fri, May 15, 2015 at 04:23:09PM -0500, Suravee Suthikulpanit wrote:
> +static inline bool acpi_dma_is_supported(struct acpi_device *adev)
> +{
> + /**
> + * Currently, we mainly support _CCA=1 (i.e. is_coherent=1)
> + * This should be equivalent to specifyig dma-coherent for
> + * a device in OF.
> + *
> + * For the case when _CCA=0 (i.e. is_coherent=0 && cca_seen=1),
> + * There are two approaches:
> + * 1. Do not support and disable DMA.
> + * 2. Support but rely on arch-specific cache maintenance for
> + * non-coherence DMA operations. ARM64 is one example.
> + *
> + * For the case when _CCA is missing (i.e. cca_seen=0) but
> + * platform specifies ACPI_CCA_REQUIRED, we do not support DMA,
> + * and fallback to arch-specific default handling.
> + *
> + * See acpi_init_coherency() for more info.
> + */
> + return adev && (adev->flags.is_coherent ||
> + (adev->flags.cca_seen && IS_ENABLED(CONFIG_ARM64)));
> +}
I don't particularly like the check for CONFIG_ARM64 here but I
understand why it was added (I had the wrong impression that x86 can
cope with _CCA = 0).
Alternatively, we could leave it out (together with cca_seen) until
someone comes forward with a real use-case for _CCA = 0 on arm64. One
platform I'm aware of is Juno but even though it boot with ACPI, I
wouldn't call it a server platform.
--
Catalin
next prev parent reply other threads:[~2015-05-20 10:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 21:23 [V4 PATCH 0/6] ACPI: Introduce support for _CCA object Suravee Suthikulpanit
2015-05-15 21:23 ` [V4 PATCH 1/6] ACPI / scan: Parse _CCA and setup device coherency Suravee Suthikulpanit
2015-05-15 23:53 ` Rafael J. Wysocki
2015-05-18 22:38 ` Suravee Suthikulanit
2015-05-19 0:28 ` Rafael J. Wysocki
2015-05-20 10:01 ` Catalin Marinas [this message]
2015-05-20 11:52 ` Suravee Suthikulanit
2015-05-20 12:04 ` [Linaro-acpi] " Arnd Bergmann
2015-05-21 13:01 ` Catalin Marinas
2015-05-21 13:24 ` Arnd Bergmann
2015-05-15 21:23 ` [V4 PATCH 2/6] arm64 : Introduce support for ACPI _CCA object Suravee Suthikulpanit
2015-05-16 11:48 ` Paul Bolle
2015-05-16 16:50 ` Suravee Suthikulpanit
2015-05-20 10:03 ` Catalin Marinas
2015-05-20 11:51 ` Suravee Suthikulanit
2015-05-15 21:23 ` [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency Suravee Suthikulpanit
2015-05-15 23:59 ` Rafael J. Wysocki
2015-05-16 15:12 ` Suthikulpanit, Suravee
2015-05-20 9:24 ` Catalin Marinas
2015-05-20 9:27 ` Arnd Bergmann
2015-05-20 9:34 ` Catalin Marinas
2015-05-20 12:00 ` Suravee Suthikulanit
2015-05-20 12:02 ` [Linaro-acpi] " Arnd Bergmann
2015-05-20 20:46 ` Russell King - ARM Linux
2015-05-20 9:31 ` Catalin Marinas
2015-05-16 12:41 ` Bjorn Helgaas
2015-05-16 15:14 ` Suthikulpanit, Suravee
2015-05-15 21:23 ` [V4 PATCH 4/6] device property: Introduces device_dma_is_coherent() Suravee Suthikulpanit
2015-05-20 10:28 ` Will Deacon
2015-05-20 21:32 ` Suravee Suthikulanit
2015-05-15 21:23 ` [V4 PATCH 5/6] crypto: ccp - Unify coherency checking logic with device_dma_is_coherent() Suravee Suthikulpanit
2015-05-15 21:23 ` [V4 PATCH 6/6] amd-xgbe: " Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520100122.GD25313@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).