From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] mtd: mxc_nand: generate nand_ecclayout for 8 bit ECC
Date: Thu, 21 May 2015 07:11:28 +0300 [thread overview]
Message-ID: <20150521041128.GI2586@tarshish> (raw)
In-Reply-To: <20150520224120.GS11598@ld-irv-0074>
Hi Brian,
On Wed, May 20, 2015 at 03:41:20PM -0700, Brian Norris wrote:
> On Wed, May 13, 2015 at 11:17:39AM +0300, Baruch Siach wrote:
> > + if (get_eccsize(mtd) == 8)
> > + ecc_8bit_layout_4k(this->ecc.layout);
>
> So you're overwriting an existing layout (e.g., nandv2_hw_eccoob_4k).
> What if you have more than one NAND chip? You might do better by
> dynamically allocating the memory.
It would take a quite a bit more code changes then that to have the mxc_nand
driver support more than one NAND chip, not to mention the DT binding. As Uwe
has indicated on a previous version of this series, ecclayout handling in this
driver could use some cleanup. This patch just fixes bug, trying to break
anything else while doing so.
Thanks for reviewing, and for applying the rest of this series.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-05-21 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 8:17 [PATCH v3 0/4] mtd: mxc_nand: fix 8 bit ECC and large oob Baruch Siach
2015-05-13 8:17 ` [PATCH v3 1/4] mtd: nand: mxc_nand: cleanup copy_spare function Baruch Siach
2015-05-13 8:17 ` [PATCH v3 2/4] mtd: mxc_nand: limit the size of used oob Baruch Siach
2015-05-13 8:17 ` [PATCH v3 3/4] mtd: mxc_nand: fix truncate of unaligned oob copying Baruch Siach
2015-05-13 8:17 ` [PATCH v3 4/4] mtd: mxc_nand: generate nand_ecclayout for 8 bit ECC Baruch Siach
2015-05-13 8:24 ` Uwe Kleine-König
2015-05-20 22:41 ` Brian Norris
2015-05-21 4:11 ` Baruch Siach [this message]
2015-05-21 4:40 ` Brian Norris
2015-05-20 22:38 ` [PATCH v3 0/4] mtd: mxc_nand: fix 8 bit ECC and large oob Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521041128.GI2586@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).