From: kwestfie@codeaurora.org (Kenneth Westfield)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: qcom: remove incorrect dependencies
Date: Thu, 21 May 2015 14:00:00 -0700 [thread overview]
Message-ID: <20150521205952.GA31005@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <2324031.cqS0mEEEhQ@wuerfel>
On Thu, May 21, 2015 at 11:07:08AM +0200, Arnd Bergmann wrote:
> Compile-tests show a warning for the newly added SND_SOC_STORM
> symbol:
>
> warning: (SND_SOC_STORM) selects SND_SOC_LPASS_CPU which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC && SND_SOC_QCOM)
>
> The problem is that it can be selected for COMPILE_TEST on non-QCOM
> builds, but the symbols it selects have a dependency.
> Dropping the dependencies makes it work without warnings and no
> other side-effects, because these are not user-visible.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: f380dd3f3cd ("ASoC: qcom: Add ability to build QCOM drivers")
>
> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
> index 5f58e4f1bca9..b07f183fc47f 100644
> --- a/sound/soc/qcom/Kconfig
> +++ b/sound/soc/qcom/Kconfig
> @@ -6,12 +6,10 @@ config SND_SOC_QCOM
>
> config SND_SOC_LPASS_CPU
> tristate
> - depends on SND_SOC_QCOM
Rather than remove the dependency (which I would like to keep), would
the following change work for SND_SOC_LPASS_CPU and
SND_SOC_LPASS_PLATFORM?
- depends on SND_SOC_QCOM
+ depends on SND_SOC_QCOM || COMPILE_TEST
If so, I will submit a patch (I know this has been applied already) on
top of this one.
> select REGMAP_MMIO
>
> config SND_SOC_LPASS_PLATFORM
> tristate
> - depends on SND_SOC_QCOM
> select REGMAP_MMIO
>
> config SND_SOC_STORM
>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-21 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 9:07 [PATCH] ASoC: qcom: remove incorrect dependencies Arnd Bergmann
2015-05-21 11:00 ` Mark Brown
2015-05-21 21:00 ` Kenneth Westfield [this message]
2015-05-21 21:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521205952.GA31005@kwestfie-linux.qualcomm.com \
--to=kwestfie@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox