From: shawn.guo@linaro.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: imx: enable smp for i.MX7D
Date: Mon, 25 May 2015 16:19:29 +0800 [thread overview]
Message-ID: <20150525081928.GK3264@dragon> (raw)
In-Reply-To: <1432147961-3547-1-git-send-email-Frank.Li@freescale.com>
On Thu, May 21, 2015 at 02:52:40AM +0800, Frank.Li at freescale.com wrote:
> From: Frank Li <Frank.Li@freescale.com>
>
> i.MX7D have two cores.
> enable multicore support.
> enable cpu hotplug support.
>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>
> Signed-off-by: Anson Huang <b20788@freescale.com>
> ---
>
> This patch is based on Russel king's
> ARM: v7 setup function should invalidate L1 cache
So we will need to wait for Russell's patch to land on mainline first.
>
> Change from V1 to V2
> - base on ARM: v7 setup function should invalidate L1 cache
> - remove unused define in gpcv2.c
> - change name imx_gpcv2_set_core1_pdn_pup_by_software to imx_gpcv2_set_core1_power
> - add timeout check.
> - Change to BUG_ON
> - Change use enable-method
>
> arch/arm/mach-imx/Kconfig | 6 ++++
> arch/arm/mach-imx/Makefile | 1 +
> arch/arm/mach-imx/common.h | 4 +++
> arch/arm/mach-imx/gpcv2.c | 67 ++++++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-imx/hotplug.c | 18 ++++++++++++
> arch/arm/mach-imx/mach-imx7d.c | 1 +
> arch/arm/mach-imx/platsmp.c | 18 ++++++++++++
> arch/arm/mach-imx/src.c | 35 ++++++++++++++++++++--
> 8 files changed, 147 insertions(+), 3 deletions(-)
> create mode 100644 arch/arm/mach-imx/gpcv2.c
Honestly, I do not like the software version numbering which is quite
arbitrary and may conflict with hardware one some day.
More importantly, is i.MX7 GPC block really so different from i.MX6 one
and worth a new driver for it? If you check the latest GPC driver, you
will find that it evolves a lot recently and becomes a driver handles
not only core power but also PU power domains, and also we have
implemented stacked IRQ domain for it. Are you going to redo all these
for this gpcv2 driver?
Shawn
next prev parent reply other threads:[~2015-05-25 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 18:52 [PATCH v2 1/2] ARM: imx: enable smp for i.MX7D Frank.Li at freescale.com
2015-05-20 18:52 ` [PATCH v2 2/2] ARM: dts: imx7d: added arch timer and gpc Frank.Li at freescale.com
2015-05-25 8:19 ` Shawn Guo [this message]
2015-05-26 15:01 ` [PATCH v2 1/2] ARM: imx: enable smp for i.MX7D Zhi Li
2015-05-27 11:54 ` Shawn Guo
2015-05-27 14:30 ` Zhi Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525081928.GK3264@dragon \
--to=shawn.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox