public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: use -marm unconditionally for THUMB2_KERNEL=n builds
Date: Wed, 27 May 2015 10:53:39 +0100	[thread overview]
Message-ID: <20150527095339.GQ2067@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1432719727-28860-1-git-send-email-u.kleine-koenig@pengutronix.de>

On Wed, May 27, 2015 at 11:42:07AM +0200, Uwe Kleine-K?nig wrote:
> The only possible culprit is a compiler that doesn't understand -marm.
> My compiler collection only goes back to 4.0.3 which does work with this
> option. The use of cc-option to test for -marm was introduced in commit
> 5636810d6f17 ([ARM] 3982/2: Explicitly select 32-bit ARM ISA (-marm))
> back in 2006 when the minimal compiler version was already 3.3.

According to gcc 3.3's --target-help, it supports -mthumb, but not -marm.

What we could possibly do is to change the := to a plain =, and then
evaluate all the options together via:

KBUILD_CFLAGS :=$(KBUILD_CFLAGS)

after their final +=.

In any case, please don't add a after the =, I've found that certain gnu
make flavours like to collect all that white space up into the executed
command, which makes reading the verbose make output more annoying.  Rule
number one of modification: stick to the established style in the file,
even if it's wrong.  Do style modifications separately and uniformly.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-05-27  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27  9:42 [PATCH RFC] ARM: use -marm unconditionally for THUMB2_KERNEL=n builds Uwe Kleine-König
2015-05-27  9:53 ` Russell King - ARM Linux [this message]
2015-05-27 14:59   ` Uwe Kleine-König
2015-05-27 17:46     ` Russell King - ARM Linux
2015-05-28 10:49       ` Dave Martin
2015-05-27 16:25 ` Nicolas Pitre
2015-05-28 10:48 ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150527095339.GQ2067@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox