From: Dave.Martin@arm.com (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: use -marm unconditionally for THUMB2_KERNEL=n builds
Date: Thu, 28 May 2015 11:48:50 +0100 [thread overview]
Message-ID: <20150528104729.GB3655@e103592.cambridge.arm.com> (raw)
In-Reply-To: <1432719727-28860-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, May 27, 2015 at 11:42:07AM +0200, Uwe Kleine-K?nig wrote:
> When using a toolchain that defaults to v7-m code generation using
> cc-option fails to add -marm because it conflicts with the default cpu
> type:
>
> $ echo > test.c
> $ arm-cortexm3-uclinuxeabi-gcc -marm -c test.c
> test.c:1:0: error: target CPU does not support ARM mode
>
> resulting in errors like
>
> Error: selected processor does not support Thumb mode `mrs r1,cpsr'
>
> Dropping the use of cc-option and using -marm unconditionally works fine
> for this compiler because it's only ever used together with $(arch-y)
> (e.g. -march=armv4).
cc-option passes the compiler flags already selected via KBUILD_CFLAGS,
so hoisting some of the append to KBUILD_CFLAGS earlier would probably
help:
KBUILD_CFLAGS += $(CFLAGS_ABI) $(arch-y) $(tune-y)
...
CFLAGS_ISA := $(call cc-option,-marm,)
...
KBUILD_CFLAGS += $(CFLAGS_ISA)
That should remove any risk of toolchain incompatibility -- but I've
not tested it...
Cheers
---Dave
[...]
prev parent reply other threads:[~2015-05-28 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 9:42 [PATCH RFC] ARM: use -marm unconditionally for THUMB2_KERNEL=n builds Uwe Kleine-König
2015-05-27 9:53 ` Russell King - ARM Linux
2015-05-27 14:59 ` Uwe Kleine-König
2015-05-27 17:46 ` Russell King - ARM Linux
2015-05-28 10:49 ` Dave Martin
2015-05-27 16:25 ` Nicolas Pitre
2015-05-28 10:48 ` Dave Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528104729.GB3655@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox