From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Fri, 29 May 2015 09:42:59 +0100 Subject: [PATCH] ARM: footbridge: enable dc21285 mtd map in defconfig In-Reply-To: <20150529064942.GB18985@pengutronix.de> References: <20150528192238.GQ27753@ld-irv-0074> <1432842380-4187-1-git-send-email-u.kleine-koenig@pengutronix.de> <20150528195558.GR27753@ld-irv-0074> <20150528210520.GE2067@n2100.arm.linux.org.uk> <20150529064942.GB18985@pengutronix.de> Message-ID: <20150529084259.GI2067@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, May 29, 2015 at 08:49:42AM +0200, Uwe Kleine-K?nig wrote: > On Thu, May 28, 2015 at 10:05:20PM +0100, Russell King - ARM Linux wrote: > > On Thu, May 28, 2015 at 12:55:58PM -0700, Brian Norris wrote: > > > On Thu, May 28, 2015 at 09:46:20PM +0200, Uwe Kleine-K?nig wrote: > > > > This driver fails to build since release 3.2. Improve compile coverage > > > > by enabling this driver in the footbridge defconfig > > > > > > Actually, it did build, but it just had alarming warnings. I don't think > > > those warnings actually affected anything at runtime, except for lock > > > debugging (if enabled). > > > > > > But anyway, the change looks good, and I'm doing this in my local build > > > tests now, so: > > > > > > > Signed-off-by: Uwe Kleine-K?nig > > > > > > Acked-by: Brian Norris > > > > I'd say no to this - some boards have old (28F008) flash on them, which > > (iirc) doesn't take kindly to being probed by MTD. > Is this a bug? I'd say keeping the driver disabled in the defconfig just > papers over a problem. Yes it is papering over a bug, but... (1) I didn't add the driver. (2) I didn't see the addition of the driver. (3) I don't have the resources to be able to recover from a screwed up flash bricking my footbridge platforms. So, I wouldn't even like to /try/ enabling it to see whether it doesn't have the behaviour I referred to. > Maybe modify the driver to not probe unless a kernel parameter is given? Possibly an alternative solution. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.