From mboxrd@z Thu Jan 1 00:00:00 1970 From: computersforpeace@gmail.com (Brian Norris) Date: Fri, 29 May 2015 10:08:18 -0700 Subject: [PATCH] mtd: use cfi-util in jedecprobe In-Reply-To: <7230287.A5AxNMN3qP@wuerfel> References: <7230287.A5AxNMN3qP@wuerfel> Message-ID: <20150529170818.GU27753@ld-irv-0074> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnd, On Fri, May 29, 2015 at 10:39:28AM +0200, Arnd Bergmann wrote: > A recent change to move cfi helper functions out of line > is causing build errors when cfi-util is a loadable module > and jedecprobe is built-in: > > drivers/built-in.o: In function `jedec_reset': > (.text+0x140694): undefined reference to `cfi_send_gen_cmd' > drivers/built-in.o: In function `jedec_probe_chip': > (.text+0x140794): undefined reference to `cfi_build_cmd_addr' > > This adds a 'select' for the module containing these functions > from the jedecprobe code, to ensure it is always reachable. > > Signed-off-by: Arnd Bergmann > Fixes: 4612c715a6ea6 ("mtd: cfi: deinline large functions") Already caught and fixed: http://patchwork.ozlabs.org/patch/477464/ Thanks!