linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900
Date: Sat, 30 May 2015 04:21:12 +0200	[thread overview]
Message-ID: <20150530022111.GA28241@earth> (raw)
In-Reply-To: <20150529193211.GA7599@amd>

Hi,

On Fri, May 29, 2015 at 09:32:11PM +0200, Pavel Machek wrote:
> Fix dts to match what the Linux kernel expects. This works around
> touchscreen problems in 4.1 linux on Nokia n900.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> index 4b641c7..09089a6 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/tsc2005.txt
> @@ -32,8 +32,8 @@ Example:
>  		touchscreen-fuzz-x = <4>;
>  		touchscreen-fuzz-y = <7>;
>  		touchscreen-fuzz-pressure = <2>;
> -		touchscreen-max-x = <4096>;
> -		touchscreen-max-y = <4096>;
> +		touchscreen-size-x = <4096>;
> +		touchscreen-size-y = <4096>;
>  		touchscreen-max-pressure = <2048>;
>  
>  		ti,x-plate-ohms = <280>;
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 5c16145..5f5e0f3 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -832,8 +832,8 @@
>  		touchscreen-fuzz-x = <4>;
>  		touchscreen-fuzz-y = <7>;
>  		touchscreen-fuzz-pressure = <2>;
> -		touchscreen-max-x = <4096>;
> -		touchscreen-max-y = <4096>;
> +		touchscreen-size-x = <4096>;
> +		touchscreen-size-y = <4096>;
>  		touchscreen-max-pressure = <2048>;
>  
>  		ti,x-plate-ohms = <280>;

Acked-By: Sebastian Reichel <sre@kernel.org>

max-x/fuzz-x is a leftover from development of the generic bindings
(Initially I used min and max).

If 3eea8b5d68c801fec788b411582b803463834752's behaviour should
become the new behaviour it should be documented, that maximum and
fuzz values are dependent on each other. Instead I suggest to
restore the old behaviour.

-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150530/2f9f6d69/attachment.sig>

      parent reply	other threads:[~2015-05-30  2:21 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201505241444.41039@pali>
     [not found] ` <20150527132545.GA23434@amd>
     [not found]   ` <20150527133311.GJ30798@pali>
     [not found]     ` <20150527143722.GA28108@amd>
     [not found]       ` <20150527145837.GA13223@earth>
     [not found]         ` <20150529190816.GA20232@amd>
     [not found]           ` <20150529192505.GA28987@amd>
2015-05-29 19:32             ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression on n900 Pavel Machek
2015-05-29 19:49               ` Felipe Balbi
2015-05-29 19:56                 ` Pavel Machek
2015-05-29 20:17                   ` Maxime Ripard
2015-05-29 20:21                     ` Felipe Balbi
2015-05-29 20:29                       ` Dmitry Torokhov
2015-05-29 20:34                         ` Pavel Machek
2015-05-29 20:48                           ` Dmitry Torokhov
2015-05-29 21:02                             ` Pavel Machek
2015-05-29 21:38                               ` Dmitry Torokhov
2015-06-01  9:55                           ` Maxime Ripard
     [not found]                             ` <20150601140605.GA26908@amd>
2015-06-01 14:58                               ` Please revert 3eea8b5d68c801fec788b411582b803463834752 as it breaks touchscreen " Maxime Ripard
2015-06-01 15:21                                 ` Pavel Machek
2015-06-01 17:47                                   ` Dmitry Torokhov
2015-06-01 20:27                                     ` Pavel Machek
2015-06-01 20:45                                       ` Dmitry Torokhov
2015-06-01 20:54                                         ` Tony Lindgren
2015-06-01 21:22                                     ` Maxime Ripard
2015-06-01 21:32                                       ` Dmitry Torokhov
2015-06-02  8:25                                         ` Pavel Machek
2015-06-02  9:44                                         ` Maxime Ripard
2015-06-02 17:58                                           ` Dmitry Torokhov
2015-06-02 18:08                                             ` Dmitry Torokhov
2015-06-25 20:25                                               ` Pavel Machek
2015-05-29 20:22                   ` [PATCH] fix n900 dts file to work around 4.1 touchscreen regression " Dmitry Torokhov
2015-05-29 20:03                 ` Maxime Ripard
2015-05-29 20:18                   ` Tony Lindgren
2015-05-29 20:30                     ` Pavel Machek
2015-05-30 10:14                   ` Pavel Machek
2015-06-01  9:49                     ` Maxime Ripard
2015-06-01  9:54                       ` Pavel Machek
2015-05-30  2:21               ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150530022111.GA28241@earth \
    --to=sre@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).