linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] clocksource: bcm_kona: Migrate to new 'set-state' interface
Date: Mon, 8 Jun 2015 21:52:42 +0530	[thread overview]
Message-ID: <20150608162242.GA4198@linux> (raw)
In-Reply-To: <5575BE20.6020102@broadcom.com>

On 08-06-15, 09:09, Ray Jui wrote:
> There's a typo here. It's "kona" not "cona"

Crap, how does this look:

From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Fri, 27 Feb 2015 13:39:52 +0530
Subject: [PATCH] clocksource: bcm_kona: Migrate to new 'set-state' interface

Migrate bcm_kona driver to the new 'set-state' interface provided by
the clockevents core, the earlier 'set-mode' interface is marked
obsolete now.

This also enables us to implement callbacks for new states of clockevent
devices, for example: ONESHOT_STOPPED.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list at broadcom.com
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/clocksource/bcm_kona_timer.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/clocksource/bcm_kona_timer.c b/drivers/clocksource/bcm_kona_timer.c
index f1e33d08dd83..9df3f1e3fd0e 100644
--- a/drivers/clocksource/bcm_kona_timer.c
+++ b/drivers/clocksource/bcm_kona_timer.c
@@ -127,25 +127,25 @@ static int kona_timer_set_next_event(unsigned long clc,
 	return 0;
 }
 
-static void kona_timer_set_mode(enum clock_event_mode mode,
-			     struct clock_event_device *unused)
+static int kona_timer_shutdown(struct clock_event_device *evt)
 {
-	switch (mode) {
-	case CLOCK_EVT_MODE_ONESHOT:
-		/* by default mode is one shot don't do any thing */
-		break;
-	case CLOCK_EVT_MODE_UNUSED:
-	case CLOCK_EVT_MODE_SHUTDOWN:
-	default:
-		kona_timer_disable_and_clear(timers.tmr_regs);
-	}
+	kona_timer_disable_and_clear(timers.tmr_regs);
+	return 0;
+}
+
+static int kona_timer_set_oneshot(struct clock_event_device *evt)
+{
+	/* By default mode is one shot, don't do any thing */
+	return 0;
 }
 
 static struct clock_event_device kona_clockevent_timer = {
 	.name = "timer 1",
 	.features = CLOCK_EVT_FEAT_ONESHOT,
 	.set_next_event = kona_timer_set_next_event,
-	.set_mode = kona_timer_set_mode
+	.set_state_shutdown = kona_timer_shutdown,
+	.set_state_oneshot = kona_timer_set_oneshot,
+	.tick_resume = kona_timer_shutdown,
 };
 
 static void __init kona_timer_clockevents_init(void)

  reply	other threads:[~2015-06-08 16:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 13:40 [PATCH 0/6] clockevent: Migrate to new 'set-state' interface Viresh Kumar
2015-06-08 13:40 ` [PATCH 1/6] clocksource: arm_arch_timer: " Viresh Kumar
2015-06-11 12:23   ` Daniel Lezcano
2015-06-11 12:57     ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 2/6] clocksource: arm_global_timer: " Viresh Kumar
2015-06-11 14:49   ` Daniel Lezcano
2015-06-11 14:56     ` Viresh Kumar
2015-06-11 14:58       ` Daniel Lezcano
2015-06-12  8:39   ` Srinivas Kandagatla
2015-06-12  8:51     ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 3/6] clocksource: bcm2835: " Viresh Kumar
2015-06-11 15:25   ` Daniel Lezcano
2015-06-11 16:00     ` Viresh Kumar
2015-06-11 16:13       ` Daniel Lezcano
2015-06-11 16:27         ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 4/6] clocksource: bcm_kona: " Viresh Kumar
2015-06-08 16:09   ` Ray Jui
2015-06-08 16:22     ` Viresh Kumar [this message]
2015-06-08 16:30       ` Ray Jui
2015-06-08 17:10         ` Ray Jui
2015-06-08 13:40 ` [PATCH 5/6] clocksource: cs5535: " Viresh Kumar
2015-06-11 15:50   ` Daniel Lezcano
2015-06-08 13:40 ` [PATCH 6/6] clocksource: em_sti: " Viresh Kumar
2015-06-11 15:53   ` Daniel Lezcano
2015-06-11 12:08 ` [PATCH 0/6] clockevent: " Daniel Lezcano
2015-06-11 13:00   ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150608162242.GA4198@linux \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).