From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away
Date: Tue, 9 Jun 2015 12:07:08 +0100 [thread overview]
Message-ID: <20150609110708.GR2982@x1> (raw)
In-Reply-To: <20150609101005.GZ14071@sirena.org.uk>
On Tue, 09 Jun 2015, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 08:03:47AM +0100, Lee Jones wrote:
>
> > Admittedly this is an extreme example, but I do consider:
>
> > init_data = of_get_regulator_init_data(<blah>);
> > if (init_data)
> > return -ENOMEM;
>
> > ... neater than:
>
> > config.init_data = of_get_regulator_init_data(<blah>);
> > if (!config.init_data)
> > return -ENOMEM;
>
> Oh, I see. I pretty much see things the other way for things where the
> temporary has no other users.
I don't feel passionate enough about it to contest.
Skip this patch then. Are you okay to continue the review?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-06-09 11:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 18:42 [PATCH 0/8] regulator: pwm-regulator: Introduce continuous-mode Lee Jones
2015-06-05 18:42 ` [PATCH 1/8] ARM: STi: STiH407: Add PWM Regulator node Lee Jones
2015-06-05 18:42 ` [PATCH 2/8] regulator: pwm-regulator: Remove unnecessary descriptor attribute from ddata Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 3/8] regulator: pwm-regulator: Remove superfluous is_enabled check Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 4/8] regulator: pwm-regulator: Diffientiate between dev (device) and rdev (regulator_dev) Lee Jones
2015-06-08 18:11 ` Mark Brown
2015-06-05 18:42 ` [PATCH 5/8] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones
2015-06-08 18:07 ` Mark Brown
2015-06-09 7:03 ` Lee Jones
2015-06-09 10:10 ` Mark Brown
2015-06-09 11:07 ` Lee Jones [this message]
2015-06-05 18:42 ` [PATCH 6/8] regulator: pwm-regulator: Separate voltage-table initialisation Lee Jones
2015-06-09 17:14 ` Mark Brown
2015-06-10 7:58 ` Lee Jones
2015-06-05 18:42 ` [PATCH 7/8] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones
2015-06-05 18:42 ` [PATCH 8/8] dt: regulator: pwm-regulator: Re-write bindings Lee Jones
2015-06-05 18:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150609110708.GR2982@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).