From mboxrd@z Thu Jan  1 00:00:00 1970
From: wsa@the-dreams.de (Wolfram Sang)
Date: Wed, 10 Jun 2015 07:19:37 +0900
Subject: [PATCH v5 4/6] i2c: at91: add support for new alternative
 command mode
In-Reply-To: <55770F43.7050707@atmel.com>
References: <cover.1433348016.git.cyrille.pitchen@atmel.com>
 <ad5348072752e523b4c677a1a986c142af716b19.1433348016.git.cyrille.pitchen@atmel.com>
 <55770F43.7050707@atmel.com>
Message-ID: <20150609221936.GB1717@katana>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Nicolas,

> > +static struct at91_twi_pdata at91sama5d2_config = {
> 
> No, please name it:
> 
> "sama5d2_config"

Thanks for your input, but please don't quote the whole mail for those
tiny comments. Only the relevant parts, please. Otherwise it is too easy
to miss things.

Thanks,

   Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150610/cf6ea07d/attachment.sig>