From: hch@lst.de (Christoph Hellwig)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark_end()
Date: Thu, 11 Jun 2015 09:31:07 +0200 [thread overview]
Message-ID: <20150611073107.GD1905@lst.de> (raw)
In-Reply-To: <20150610053803.GA1693@gondor.apana.org.au>
On Wed, Jun 10, 2015 at 01:38:04PM +0800, Herbert Xu wrote:
> On Tue, Jun 09, 2015 at 12:27:15PM -0400, Dan Williams wrote:
> >
> > +#define scatterwalk_sg_chain(prv, num, sgl) sg_chain(prv, num, sgl)
> > +#define scatterwalk_sg_next(sgl) sg_next(sgl)
>
> Why are you reintroducing the scatterwalk_sg_next macro that we
> just removed?
>
> I also don't understand why this is so urgent that it has to go
> into mainline at this late date.
It allows getting a cleaner slate for the next merge window, which seems
useful on it's own. The re-addition of scatterwalk_sg_next seems next,
but getting rid of the open-coded sg_chain is useful.
Maybe you can take it through the crypto tree and also kill off the
scatterwalk_sg_chain name as well while we're at it?
next prev parent reply other threads:[~2015-06-11 7:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 16:27 [PATCH 0/2] scatterlist cleanups Dan Williams
2015-06-09 16:27 ` [PATCH 1/2] scatterlist: use sg_phys() Dan Williams
2015-06-10 0:34 ` Elliott, Robert (Server Storage)
2015-06-10 9:32 ` Joerg Roedel
2015-06-10 16:00 ` Dan Williams
2015-06-10 16:31 ` Russell King - ARM Linux
2015-06-10 16:57 ` Dan Williams
2015-06-10 17:13 ` Russell King - ARM Linux
2015-06-10 17:25 ` Dan Williams
2015-06-11 6:50 ` Joerg Roedel
2015-06-09 16:27 ` [PATCH 2/2] scatterlist: cleanup sg_chain() and sg_unmark_end() Dan Williams
2015-06-10 5:38 ` Herbert Xu
2015-06-11 7:31 ` Christoph Hellwig [this message]
2015-06-11 7:34 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611073107.GD1905@lst.de \
--to=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).