From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] clocksource: arm_global_timer: Migrate to new 'set-state' interface
Date: Thu, 11 Jun 2015 20:26:54 +0530 [thread overview]
Message-ID: <20150611145654.GB4386@linux> (raw)
In-Reply-To: <5579A011.8030900@linaro.org>
On 11-06-15, 16:49, Daniel Lezcano wrote:
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Thanks :)
> >- clk->set_mode = gt_clockevent_set_mode;
> >+ clk->set_state_shutdown = gt_clockevent_shutdown;
> >+ clk->set_state_periodic = gt_clockevent_set_periodic;
> >+ clk->set_state_oneshot = gt_clockevent_shutdown;
>
> nit: it sounds weird to use the same function as the purpose of the
> patch is use the new API which is to ventilate those functions
> (anyway ...)
Hmm, but there is no point creating two routines to do exactly the
same thing. And this is making it evident that we actually shutdown
the device in oneshot-state request. And enable it only when the next
event is programmed.
--
viresh
next prev parent reply other threads:[~2015-06-11 14:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 13:40 [PATCH 0/6] clockevent: Migrate to new 'set-state' interface Viresh Kumar
2015-06-08 13:40 ` [PATCH 1/6] clocksource: arm_arch_timer: " Viresh Kumar
2015-06-11 12:23 ` Daniel Lezcano
2015-06-11 12:57 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 2/6] clocksource: arm_global_timer: " Viresh Kumar
2015-06-11 14:49 ` Daniel Lezcano
2015-06-11 14:56 ` Viresh Kumar [this message]
2015-06-11 14:58 ` Daniel Lezcano
2015-06-12 8:39 ` Srinivas Kandagatla
2015-06-12 8:51 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 3/6] clocksource: bcm2835: " Viresh Kumar
2015-06-11 15:25 ` Daniel Lezcano
2015-06-11 16:00 ` Viresh Kumar
2015-06-11 16:13 ` Daniel Lezcano
2015-06-11 16:27 ` Viresh Kumar
2015-06-08 13:40 ` [PATCH 4/6] clocksource: bcm_kona: " Viresh Kumar
2015-06-08 16:09 ` Ray Jui
2015-06-08 16:22 ` Viresh Kumar
2015-06-08 16:30 ` Ray Jui
2015-06-08 17:10 ` Ray Jui
2015-06-08 13:40 ` [PATCH 5/6] clocksource: cs5535: " Viresh Kumar
2015-06-11 15:50 ` Daniel Lezcano
2015-06-08 13:40 ` [PATCH 6/6] clocksource: em_sti: " Viresh Kumar
2015-06-11 15:53 ` Daniel Lezcano
2015-06-11 12:08 ` [PATCH 0/6] clockevent: " Daniel Lezcano
2015-06-11 13:00 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150611145654.GB4386@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).