From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Mon, 15 Jun 2015 13:31:35 +0200 Subject: [RESEND PATCH v4 04/14] crypto: add a new driver for Marvell's CESA In-Reply-To: <20150615095421.GA32158@gondor.apana.org.au> References: <1434093366-14681-1-git-send-email-boris.brezillon@free-electrons.com> <1434093366-14681-5-git-send-email-boris.brezillon@free-electrons.com> <20150615095421.GA32158@gondor.apana.org.au> Message-ID: <20150615133135.47ffd3e3@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 15 Jun 2015 17:54:21 +0800 Herbert Xu wrote: > On Fri, Jun 12, 2015 at 09:15:56AM +0200, Boris Brezillon wrote: > > > > +static int mv_cesa_cbc_aes_op(struct ablkcipher_request *req, > > + struct mv_cesa_op_ctx *tmpl) > > +{ > > + mv_cesa_update_op_cfg(tmpl, CESA_SA_DESC_CFG_CRYPTCM_CBC, > > + CESA_SA_DESC_CFG_CRYPTCM_MSK); > > + memcpy(tmpl->ctx.blkcipher.iv, req->info, 16); > > You need to copy the IV back into req->info after completion. I haven't found any driver updating the req->info field with the new IV. Could you point me to one of them. > > Incidentally we don't seem to test for output IVs in our self- > test so bugs like this can slip through until someone tries to > do chaining with it. That's something worth adding to testmgr. Yes, that makes sense, but since a lot a drivers (if not all of them) are not updating this field we'll break them when adding this test unless we make it optional (with a new flag ?). Do you have any suggestion to address this problem ? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com