* [BUG] at91: macb: does not work
@ 2015-06-16 13:10 Jiří Prchal
2015-06-16 13:24 ` Boris Brezillon
2015-06-16 13:31 ` Alexandre Belloni
0 siblings, 2 replies; 7+ messages in thread
From: Jiří Prchal @ 2015-06-16 13:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
[ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
[ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
[ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
[ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
/ # ip -s link ls eth0
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
RX: bytes packets errors dropped overrun mcast
0 0 0 0 0 0
TX: bytes packets errors dropped carrier collsns
0 0 0 0 0 0
In v4.0.5 it's working.
I bisected it and found:
a848748959d554666b34cffc08ef2d23f4bb2990 is the first bad commit
commit a848748959d554666b34cffc08ef2d23f4bb2990
Author: Boris BREZILLON <boris.brezillon@free-electrons.com>
Date: Sat Mar 7 07:23:30 2015 +0100
net: macb: remove #if defined(CONFIG_ARCH_AT91) sections
With multi platform support those sections could lead to unexpected
behavior if both ARCH_AT91 and another ARM SoC using the MACB IP are
selected.
Add two new capabilities to encode the default MII mode and the presence
of a CLKEN bit in USRIO register.
Then define the appropriate config for IPs embedded in at91 SoCs.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
:040000 040000 1c87dbb47362b56e88a0e7256c991c64cf60e0bf af0bcc11f81aebf2c64afa5cd53766d494ea3fdb M drivers
Jiri
^ permalink raw reply [flat|nested] 7+ messages in thread* [BUG] at91: macb: does not work
2015-06-16 13:10 [BUG] at91: macb: does not work Jiří Prchal
@ 2015-06-16 13:24 ` Boris Brezillon
2015-06-16 13:32 ` Sylvain Rochet
2015-06-16 13:32 ` Jiří Prchal
2015-06-16 13:31 ` Alexandre Belloni
1 sibling, 2 replies; 7+ messages in thread
From: Boris Brezillon @ 2015-06-16 13:24 UTC (permalink / raw)
To: linux-arm-kernel
Hi Jiri,
On Tue, 16 Jun 2015 15:10:51 +0200
Ji?? Prchal <jiri.prchal@aksignal.cz> wrote:
> Hi,
> in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
>
> [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
> [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
> [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
> [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
>
> / # ip -s link ls eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
> link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 0 0 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 0 0 0 0 0 0
>
> In v4.0.5 it's working.
On which platform are you testing (SoC and board) ?
Best Regards,
Boris
>
> I bisected it and found:
> a848748959d554666b34cffc08ef2d23f4bb2990 is the first bad commit
> commit a848748959d554666b34cffc08ef2d23f4bb2990
> Author: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Date: Sat Mar 7 07:23:30 2015 +0100
>
> net: macb: remove #if defined(CONFIG_ARCH_AT91) sections
>
> With multi platform support those sections could lead to unexpected
> behavior if both ARCH_AT91 and another ARM SoC using the MACB IP are
> selected.
> Add two new capabilities to encode the default MII mode and the presence
> of a CLKEN bit in USRIO register.
> Then define the appropriate config for IPs embedded in at91 SoCs.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> :040000 040000 1c87dbb47362b56e88a0e7256c991c64cf60e0bf af0bcc11f81aebf2c64afa5cd53766d494ea3fdb M drivers
>
>
> Jiri
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [BUG] at91: macb: does not work
2015-06-16 13:24 ` Boris Brezillon
@ 2015-06-16 13:32 ` Sylvain Rochet
2015-06-16 14:47 ` Sylvain Rochet
2015-06-16 13:32 ` Jiří Prchal
1 sibling, 1 reply; 7+ messages in thread
From: Sylvain Rochet @ 2015-06-16 13:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello Ji??,
On Tue, Jun 16, 2015 at 03:24:54PM +0200, Boris Brezillon wrote:
> Hi Jiri,
>
> On Tue, 16 Jun 2015 15:10:51 +0200
> Ji?? Prchal <jiri.prchal@aksignal.cz> wrote:
>
> > Hi,
> > in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
> >
> > [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
> > [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
> > [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
> > [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
> >
> > / # ip -s link ls eth0
> > 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
> > link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
> > RX: bytes packets errors dropped overrun mcast
> > 0 0 0 0 0 0
> > TX: bytes packets errors dropped carrier collsns
> > 0 0 0 0 0 0
> >
> > In v4.0.5 it's working.
>
> On which platform are you testing (SoC and board) ?
I guess I'm also affected by this issue, but contrary to Ji?? my eth0
interface passes traffic a minute or so after booting up.
This doesn't seem to be related with TM9000 screen and the ETH0/QT1070
hardware IRQ sharing.
Sylvain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150616/ade22d02/attachment.sig>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [BUG] at91: macb: does not work
2015-06-16 13:24 ` Boris Brezillon
2015-06-16 13:32 ` Sylvain Rochet
@ 2015-06-16 13:32 ` Jiří Prchal
1 sibling, 0 replies; 7+ messages in thread
From: Jiří Prchal @ 2015-06-16 13:32 UTC (permalink / raw)
To: linux-arm-kernel
On 16.6.2015 15:24, Boris Brezillon wrote:
> Hi Jiri,
>
> On Tue, 16 Jun 2015 15:10:51 +0200
> Ji?? Prchal <jiri.prchal@aksignal.cz> wrote:
>
>> Hi,
>> in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
>>
>> [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
>> [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
>> [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
>> [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
>>
>> / # ip -s link ls eth0
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
>> link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
>> RX: bytes packets errors dropped overrun mcast
>> 0 0 0 0 0 0
>> TX: bytes packets errors dropped carrier collsns
>> 0 0 0 0 0 0
>>
>> In v4.0.5 it's working.
>
> On which platform are you testing (SoC and board) ?
Oh, sorry.
[ 0.000000] AT91: Detected soc subtype: at91sam9g25
Board design like at91sam9x5ek.
Phy: DM9161BEP
Used RMII.
Jiri
>
> Best Regards,
>
> Boris
>
>>
>> I bisected it and found:
>> a848748959d554666b34cffc08ef2d23f4bb2990 is the first bad commit
>> commit a848748959d554666b34cffc08ef2d23f4bb2990
>> Author: Boris BREZILLON <boris.brezillon@free-electrons.com>
>> Date: Sat Mar 7 07:23:30 2015 +0100
>>
>> net: macb: remove #if defined(CONFIG_ARCH_AT91) sections
>>
>> With multi platform support those sections could lead to unexpected
>> behavior if both ARCH_AT91 and another ARM SoC using the MACB IP are
>> selected.
>> Add two new capabilities to encode the default MII mode and the presence
>> of a CLKEN bit in USRIO register.
>> Then define the appropriate config for IPs embedded in at91 SoCs.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>> Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> Signed-off-by: David S. Miller <davem@davemloft.net>
>>
>> :040000 040000 1c87dbb47362b56e88a0e7256c991c64cf60e0bf af0bcc11f81aebf2c64afa5cd53766d494ea3fdb M drivers
>>
>>
>> Jiri
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [BUG] at91: macb: does not work
2015-06-16 13:10 [BUG] at91: macb: does not work Jiří Prchal
2015-06-16 13:24 ` Boris Brezillon
@ 2015-06-16 13:31 ` Alexandre Belloni
2015-06-16 14:05 ` Jiří Prchal
1 sibling, 1 reply; 7+ messages in thread
From: Alexandre Belloni @ 2015-06-16 13:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 16/06/2015 at 15:10:51 +0200, Ji?? Prchal wrote :
> Hi,
> in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
>
> [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
> [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
> [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
> [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
>
> / # ip -s link ls eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
> link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 0 0 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 0 0 0 0 0 0
>
> In v4.0.5 it's working.
>
You probably have an issue in your device tree. I've just tested both
interfaces of my sama5d3 xplained and they are working fine.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [BUG] at91: macb: does not work
2015-06-16 13:31 ` Alexandre Belloni
@ 2015-06-16 14:05 ` Jiří Prchal
0 siblings, 0 replies; 7+ messages in thread
From: Jiří Prchal @ 2015-06-16 14:05 UTC (permalink / raw)
To: linux-arm-kernel
On 16.6.2015 15:31, Alexandre Belloni wrote:
> Hi,
>
> On 16/06/2015 at 15:10:51 +0200, Ji?? Prchal wrote :
>> Hi,
>> in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
>>
>> [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
>> [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
>> [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
>> [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
>>
>> / # ip -s link ls eth0
>> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
>> link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
>> RX: bytes packets errors dropped overrun mcast
>> 0 0 0 0 0 0
>> TX: bytes packets errors dropped carrier collsns
>> 0 0 0 0 0 0
>>
>> In v4.0.5 it's working.
>>
>
> You probably have an issue in your device tree. I've just tested both
> interfaces of my sama5d3 xplained and they are working fine.
Sorry for that, I compiled and loaded dtb and it works now.
(Just forget that "make" doesn't compile dtb.)
Thanks
Jiri
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-16 14:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-16 13:10 [BUG] at91: macb: does not work Jiří Prchal
2015-06-16 13:24 ` Boris Brezillon
2015-06-16 13:32 ` Sylvain Rochet
2015-06-16 14:47 ` Sylvain Rochet
2015-06-16 13:32 ` Jiří Prchal
2015-06-16 13:31 ` Alexandre Belloni
2015-06-16 14:05 ` Jiří Prchal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).