From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] at91: macb: does not work
Date: Tue, 16 Jun 2015 15:24:54 +0200 [thread overview]
Message-ID: <20150616152454.348ae4ea@bbrezillon> (raw)
In-Reply-To: <5580205B.1030804@aksignal.cz>
Hi Jiri,
On Tue, 16 Jun 2015 15:10:51 +0200
Ji?? Prchal <jiri.prchal@aksignal.cz> wrote:
> Hi,
> in v4.1-rc8 does not work ethernet. It normally gets up, but no data are going through.
>
> [ 4.400000] macb f802c000.ethernet (unnamed net_device) (uninitialized): invalid hw address, using random
> [ 4.510000] macb f802c000.ethernet eth0: Cadence MACB rev 0x0001010c at 0xf802c000 irq 37 (52:30:8f:6b:9c:b7)
> [ 4.520000] macb f802c000.ethernet eth0: attached PHY driver [Generic PHY] (mii_bus:phy_addr=f802c000.etherne:03, irq=-1)
> [ 15.510000] macb f802c000.ethernet eth0: link up (100/Full)
>
> / # ip -s link ls eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000
> link/ether a2:61:fe:17:65:b1 brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 0 0 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 0 0 0 0 0 0
>
> In v4.0.5 it's working.
On which platform are you testing (SoC and board) ?
Best Regards,
Boris
>
> I bisected it and found:
> a848748959d554666b34cffc08ef2d23f4bb2990 is the first bad commit
> commit a848748959d554666b34cffc08ef2d23f4bb2990
> Author: Boris BREZILLON <boris.brezillon@free-electrons.com>
> Date: Sat Mar 7 07:23:30 2015 +0100
>
> net: macb: remove #if defined(CONFIG_ARCH_AT91) sections
>
> With multi platform support those sections could lead to unexpected
> behavior if both ARCH_AT91 and another ARM SoC using the MACB IP are
> selected.
> Add two new capabilities to encode the default MII mode and the presence
> of a CLKEN bit in USRIO register.
> Then define the appropriate config for IPs embedded in at91 SoCs.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reviewed-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> :040000 040000 1c87dbb47362b56e88a0e7256c991c64cf60e0bf af0bcc11f81aebf2c64afa5cd53766d494ea3fdb M drivers
>
>
> Jiri
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-16 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 13:10 [BUG] at91: macb: does not work Jiří Prchal
2015-06-16 13:24 ` Boris Brezillon [this message]
2015-06-16 13:32 ` Sylvain Rochet
2015-06-16 14:47 ` Sylvain Rochet
2015-06-16 13:32 ` Jiří Prchal
2015-06-16 13:31 ` Alexandre Belloni
2015-06-16 14:05 ` Jiří Prchal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616152454.348ae4ea@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).