linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT
Date: Wed, 17 Jun 2015 19:03:14 +0530	[thread overview]
Message-ID: <20150617133314.GB15153@linux> (raw)
In-Reply-To: <CAL_Jsq+EOOeQw42wZi+H82ovLn8LcQUuK9HGT+FvewdhTf7Q1w@mail.gmail.com>

On 17-06-15, 08:23, Rob Herring wrote:
> > +                       operating-points-v2 = <&cpu0_opp_table_slow>, <&cpu0_opp_table_fast>;
> 
> You've made a fundamental change here in that this can now be a list
> of phandles. There should be some description on what a list means
> (merge the tables?, select one?).

Did you miss the description I wrote few lines earlier or are you
asking for something else? This is what I wrote earlier:

> > +Devices may want to choose OPP tables at runtime and so can provide a list of
> > +phandles here. But only *one* of them should be chosen at runtime.

So, clearly only ONE of the tables should be used.

> I think this needs to have a defined order and the platform should
> know what that is. For example, if you read the efuses and decide you
> need the "slow" table, you know to pick the first entry. Then you
> don't need opp-name. Does that work for QCom?

Why forcing on the order here? For example, consider a case where the
platform can have four tables, A B C D. Now DT is free to pass all
four or just a subset of those. Like, for some boards table B doesn't
stand valid. And so it may wanna pass just A C D. And so keeping these
tables in order is going to break for sure. Flexibility is probably
better in this case.

-- 
viresh

  reply	other threads:[~2015-06-17 13:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-04 16:20 [PATCH V7 0/3] OPP: Introduce OPP (V2) bindings Viresh Kumar
2015-06-04 16:20 ` [PATCH V7 1/3] OPP: Add new bindings to address shortcomings of existing bindings Viresh Kumar
2015-06-04 18:37   ` Stephen Boyd
2015-06-05  2:41     ` Viresh Kumar
2015-06-16 13:34   ` Nishanth Menon
2015-06-04 16:20 ` [PATCH V7 2/3] OPP: Allow multiple OPP tables to be passed via DT Viresh Kumar
2015-06-17 13:23   ` Rob Herring
2015-06-17 13:33     ` Viresh Kumar [this message]
2015-06-17 13:47       ` Rob Herring
2015-06-17 14:42         ` Viresh Kumar
2015-06-18  1:30         ` Stephen Boyd
2015-06-18  2:25           ` Viresh Kumar
2015-06-18  2:50             ` Viresh Kumar
2015-06-19 18:47               ` Stephen Boyd
2015-06-19 18:52                 ` Rob Herring
2015-06-20  2:24                   ` Viresh Kumar
2015-06-19 18:44             ` Stephen Boyd
2015-06-20  2:18               ` Viresh Kumar
2015-06-04 16:20 ` [PATCH V7 3/3] OPP: Add binding for 'opp-suspend' Viresh Kumar
2015-06-13  8:40   ` Viresh Kumar
2015-06-15 22:30     ` Rafael J. Wysocki
2015-06-15 23:35   ` Rob Herring
2015-06-16  0:31     ` Viresh Kumar
2015-06-16  2:54       ` Viresh Kumar
2015-06-16 19:23         ` Rob Herring
2015-06-16 21:21           ` Rafael J. Wysocki
2015-06-17  2:38             ` Viresh Kumar
2015-06-17  9:38               ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150617133314.GB15153@linux \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).