From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] i2c: omap: improve duty cycle on SCL
Date: Wed, 17 Jun 2015 14:00:49 -0500 [thread overview]
Message-ID: <20150617190049.GI18421@saruman.tx.rr.com> (raw)
In-Reply-To: <5581C3E5.6020109@gmail.com>
On Wed, Jun 17, 2015 at 09:00:53PM +0200, Alexander Sverdlin wrote:
> Hi!
>
> On 17/06/15 20:29, Felipe Balbi wrote:
> > - if (dev->speed > 400 ||
> > - dev->flags & OMAP_I2C_FLAG_FORCE_19200_INT_CLK)
> > - internal_clk = 19200;
>
> Let's compare, what it waas before in this case...
>
> > - else if (dev->speed > 100)
> > - internal_clk = 9600;
> > - else
> > - internal_clk = 4000;
> > + if (dev->flags & OMAP_I2C_FLAG_FORCE_19200_INT_CLK ||
> > + dev->speed > 400) {
> > + internal_clk = 1920000;
>
> Seems that it should be 19200000? Because...
indeed, it's missing one 0. I don't have OMAP3 board to test that out,
that's why I asked Aaro to run the test. v3 coming.
--
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150617/cd157eaa/attachment.sig>
prev parent reply other threads:[~2015-06-17 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 18:29 [PATCH v2] i2c: omap: improve duty cycle on SCL Felipe Balbi
2015-06-17 19:00 ` Alexander Sverdlin
2015-06-17 19:00 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150617190049.GI18421@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox