From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: at91: add generated clock driver
Date: Thu, 18 Jun 2015 09:33:44 +0200 [thread overview]
Message-ID: <20150618093344.7d486e97@bbrezillon> (raw)
In-Reply-To: <1434611556.2385.8.camel@x220>
Hi Paul,
On Thu, 18 Jun 2015 09:12:36 +0200
Paul Bolle <pebolle@tiscali.nl> wrote:
> On Wed, 2015-06-17 at 15:23 +0200, Nicolas Ferre wrote:
>
> > --- a/arch/arm/mach-at91/Kconfig
> > +++ b/arch/arm/mach-at91/Kconfig
>
> > +config HAVE_AT91_GENERATED
> > + bool
>
> This will always be 'n'.
>
> > --- a/drivers/clk/at91/Makefile
> > +++ b/drivers/clk/at91/Makefile
>
> > +obj-$(CONFIG_HAVE_AT91_GENERATED) += clk-generated.o
>
> And clk-generated.o will never be built.
>
> I think your options are to use
> config HAVE_AT91_GENERATED
> def_bool y
>
> or
> config HAVE_AT91_GENERATED
> bool "Yadda yadda yadda"
>
> or add
> select HAVE_AT91_GENERATED
>
> somewhere (possibly even in a second patch). But as it stands the patch
> looks like an elaborate NOP.
I guess it will be selected by platforms embedding such clks. We just
have to wait for those platform to reach mainline ;-).
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-18 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 13:23 [PATCH] clk: at91: add generated clock driver Nicolas Ferre
2015-06-18 7:12 ` Paul Bolle
2015-06-18 7:33 ` Boris Brezillon [this message]
2015-06-18 7:40 ` Nicolas Ferre
2015-06-18 7:54 ` Paul Bolle
2015-06-18 12:40 ` Nicolas Ferre
2015-06-18 14:46 ` Paul Bolle
2015-06-18 12:59 ` Alexandre Belloni
2015-06-18 13:28 ` Nicolas Ferre
2015-06-18 15:11 ` Paul Bolle
2015-06-18 7:44 ` Paul Bolle
2015-06-18 15:25 ` Boris Brezillon
2015-06-22 16:50 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150618093344.7d486e97@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).