From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit
Date: Fri, 19 Jun 2015 15:32:39 -0700 [thread overview]
Message-ID: <20150619223239.GA24540@dtor-ws> (raw)
In-Reply-To: <4b10b4bf7824134dfc91c5e4f25de3086163bba7.1434703451.git.cyrille.pitchen@atmel.com>
Hi Cyrille,
On Fri, Jun 19, 2015 at 10:49:35AM +0200, Cyrille Pitchen wrote:
> +
> + clk_prepare_enable(clk);
I believe you need to have error handling here, not because it will
actually fail but to handle deferrals.
> + version = readl(map + FX_VERSION);
> + writel(mr, map + FX_MR);
> + clk_disable_unprepare(clk);
> +
> + dev_info(&pdev->dev, "version: %#x, mode: %s\n", version, mode);
> +
> + return of_platform_populate(pdev->dev.of_node, NULL, NULL, &pdev->dev);
> +}
Thanks.
--
Dmitry
prev parent reply other threads:[~2015-06-19 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 8:49 [PATCH v3 0/2] mfd: flexcom: add a driver for Flexcom Cyrille Pitchen
2015-06-19 8:49 ` [PATCH v3 1/2] mfd: devicetree: add bindings for Atmel Flexcom Cyrille Pitchen
2015-06-19 8:49 ` [PATCH v3 2/2] mfd: flexcom: add a driver for Atmel Flexible Serial Communication Unit Cyrille Pitchen
2015-06-19 22:32 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150619223239.GA24540@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).