From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC
Date: Thu, 25 Jun 2015 16:18:00 +0100 [thread overview]
Message-ID: <20150625151800.GC6844@leverpostej> (raw)
In-Reply-To: <1434644382-11905-1-git-send-email-anuragku@xilinx.com>
On Thu, Jun 18, 2015 at 05:19:42PM +0100, Anurag Kumar Vulisha wrote:
> Removed the workarounds present in the cadence i2c driver for
> Zynq Ultrascale+ MPSoC
I guess this means that cdns,i2c-r1p10 had quirks fixed in
cdns,i2c-r1p14? It would be helpful to be a bit more explicit in the
commit message.
>
> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>
> ---
> .../devicetree/bindings/i2c/i2c-cadence.txt | 2 +-
> drivers/i2c/busses/i2c-cadence.c | 67 ++++++++++++++++---
> 2 files changed, 57 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> index 7cb0b56..11ef7f2 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-cadence.txt
> @@ -2,7 +2,7 @@ Binding for the Cadence I2C controller
>
> Required properties:
> - reg: Physical base address and size of the controller's register area.
> - - compatible: Compatibility string. Must be 'cdns,i2c-r1p10'.
> + - compatible: Compatibility string.Use 'cdns,i2c-r1p10' or 'cdns,i2c-r1p14'
Please format this as a list. It aids legibility and expansion. e.g:
- compatible: should contain one of:
* "cdns,i2c-r1p10"
* "cdns,i2c-r1p14"
Perhaps with notes as to the differences.
Thanks,
Mark.
next prev parent reply other threads:[~2015-06-25 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 16:19 [PATCH] i2c: removed work arounds in i2c driver for Zynq Ultrascale+ MPSoC Anurag Kumar Vulisha
2015-06-25 15:18 ` Mark Rutland [this message]
2015-07-09 20:09 ` Wolfram Sang
2015-07-10 7:29 ` Anurag Kumar Vulisha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625151800.GC6844@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox