From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze()
Date: Mon, 29 Jun 2015 11:00:51 +0200 [thread overview]
Message-ID: <20150629090050.GD5431@ulmo> (raw)
In-Reply-To: <CAAObsKCURyo-ujcA7r+UYqSw6ie-aBxKiYEdTKwe-HrL14RkBw@mail.gmail.com>
On Thu, Jun 18, 2015 at 09:09:29AM +0200, Tomeu Vizoso wrote:
> On 21 May 2015 at 03:02, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Tuesday, May 19, 2015 04:49:12 PM Tomeu Vizoso wrote:
> >> This callback is expected to do the same as enter() but it has to
> >> guarantee that interrupts aren't enabled at any point in its execution,
> >> as the tick is frozen.
> >>
> >> It will be called when the system goes to suspend-to-idle and will
> >> reduce power usage because CPUs won't be awaken for unnecessary IRQs.
> >>
> >> By setting the CPUIDLE_FLAG_TIMER_STOP flag, we can reuse the same code
> >> for both the enter() and enter_freeze() callbacks.
> >>
> >> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> >> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Makes sense to me, but I suppose it should go in via arm-soc.
>
> Hi Thierry,
>
> what's the plan regarding merging of this patch?
>
> It needs df8d9ee ("cpuidle: Run tick_broadcast_exit() with disabled
> interrupts") so it doesn't break boot.
By the looks of it the above patch was merged in 4.1, so I can easily
take this through the Tegra tree. The commit message doesn't say whether
or not this fixes a bug. Is this urgent? Should it go into 4.2? It
sounds more like it's a power-saving feature, so 4.3 is probably more
appropriate.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150629/fe9572c4/attachment.sig>
next prev parent reply other threads:[~2015-06-29 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 14:49 [PATCH v3] ARM: tegra: cpuidle: implement cpuidle_state.enter_freeze() Tomeu Vizoso
2015-05-20 8:44 ` Lorenzo Pieralisi
2015-05-20 8:55 ` Tomeu Vizoso
2015-05-20 9:04 ` Lorenzo Pieralisi
2015-05-21 1:02 ` Rafael J. Wysocki
2015-06-18 7:09 ` Tomeu Vizoso
2015-06-29 9:00 ` Thierry Reding [this message]
2015-06-29 9:18 ` Tomeu Vizoso
2015-08-13 14:54 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629090050.GD5431@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).