* [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init
@ 2015-07-02 1:33 Jisheng Zhang
2015-07-02 1:56 ` Krzysztof Kozlowski
2015-07-02 16:45 ` Catalin Marinas
0 siblings, 2 replies; 4+ messages in thread
From: Jisheng Zhang @ 2015-07-02 1:33 UTC (permalink / raw)
To: linux-arm-kernel
It is not needed after booting, this patch moves the arm_cpuidle_init()
function to the __init section.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
arch/arm64/kernel/cpuidle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/cpuidle.c b/arch/arm64/kernel/cpuidle.c
index 7ce589c..9047cab6 100644
--- a/arch/arm64/kernel/cpuidle.c
+++ b/arch/arm64/kernel/cpuidle.c
@@ -15,7 +15,7 @@
#include <asm/cpuidle.h>
#include <asm/cpu_ops.h>
-int arm_cpuidle_init(unsigned int cpu)
+int __init arm_cpuidle_init(unsigned int cpu)
{
int ret = -EOPNOTSUPP;
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init
2015-07-02 1:33 [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init Jisheng Zhang
@ 2015-07-02 1:56 ` Krzysztof Kozlowski
2015-07-02 2:16 ` Jisheng Zhang
2015-07-02 16:45 ` Catalin Marinas
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-02 1:56 UTC (permalink / raw)
To: linux-arm-kernel
2015-07-02 10:33 GMT+09:00 Jisheng Zhang <jszhang@marvell.com>:
> It is not needed after booting, this patch moves the arm_cpuidle_init()
> function to the __init section.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> arch/arm64/kernel/cpuidle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks good but I think you can also mark the stub in
arch/arm64/include/asm/cpuidle.h.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init
2015-07-02 1:56 ` Krzysztof Kozlowski
@ 2015-07-02 2:16 ` Jisheng Zhang
0 siblings, 0 replies; 4+ messages in thread
From: Jisheng Zhang @ 2015-07-02 2:16 UTC (permalink / raw)
To: linux-arm-kernel
Dear Krzysztof,
On Thu, 2 Jul 2015 10:56:47 +0900
Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-07-02 10:33 GMT+09:00 Jisheng Zhang <jszhang@marvell.com>:
> > It is not needed after booting, this patch moves the arm_cpuidle_init()
> > function to the __init section.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > ---
> > arch/arm64/kernel/cpuidle.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This looks good but I think you can also mark the stub in
> arch/arm64/include/asm/cpuidle.h.
>
Thanks for review. Has adopted your suggestion in v2.
Thanks,
Jisheng
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init
2015-07-02 1:33 [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init Jisheng Zhang
2015-07-02 1:56 ` Krzysztof Kozlowski
@ 2015-07-02 16:45 ` Catalin Marinas
1 sibling, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2015-07-02 16:45 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 02, 2015 at 09:33:07AM +0800, Jisheng Zhang wrote:
> It is not needed after booting, this patch moves the arm_cpuidle_init()
> function to the __init section.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Applied. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-02 16:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-02 1:33 [PATCH] arm64: cpuidle: add __init section marker to arm_cpuidle_init Jisheng Zhang
2015-07-02 1:56 ` Krzysztof Kozlowski
2015-07-02 2:16 ` Jisheng Zhang
2015-07-02 16:45 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).