From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap
Date: Thu, 2 Jul 2015 11:55:39 +0100 [thread overview]
Message-ID: <20150702105539.GB13036@leverpostej> (raw)
In-Reply-To: <20150702103930.GQ7557@n2100.arm.linux.org.uk>
> > I could retain the struct and packing functions for the two cases you
> > mention, but it seemed somewhat misleading. I'll see if I can figure out
> > something better than a raw hex value.
>
> What's wrong with a few #defines for this?
Nothing.
> It obviously is well enough defined in existing pre-v1.0
> implementations as there is an existing structure to the parameter.
>
> Can we not do something like:
>
> #define PSCI_POWER_STATE_ID(x) (x)
> #define PSCI_POWER_STATE_TYPE_POWER_DOWN 0x000100000
> #define PSCI_POWER_STATE_AFFINITY_LEVEL(x) ((x) << 24)
Looks good.
We already have some constants defined in a UAPI header, so I'll see
about reusing those.
Thanks,
Mark.
prev parent reply other threads:[~2015-07-02 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 10:44 [PATCH] ARM: psci: boot_secondary: replace __pa with virt_to_idmap Grygorii Strashko
2015-06-30 14:50 ` santosh shilimkar
2015-06-30 15:05 ` Russell King - ARM Linux
2015-06-30 15:59 ` Nicolas Pitre
2015-06-30 16:28 ` Vitaly Andrianov
2015-06-30 16:18 ` Mark Rutland
2015-06-30 20:25 ` Russell King - ARM Linux
2015-07-02 10:07 ` Grygorii Strashko
2015-07-02 10:29 ` Mark Rutland
2015-07-02 10:39 ` Russell King - ARM Linux
2015-07-02 10:55 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702105539.GB13036@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox