linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5] arm DMA: Fix allocation from CMA for coherent DMA
Date: Fri, 3 Jul 2015 10:03:06 +0100	[thread overview]
Message-ID: <20150703090305.GR7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150701111251.GA21981@e104818-lin.cambridge.arm.com>

On Wed, Jul 01, 2015 at 12:12:51PM +0100, Catalin Marinas wrote:
> On Tue, Jun 30, 2015 at 11:29:06PM +0200, Lorenzo Nava wrote:
> > This patch allows the use of CMA for DMA coherent memory allocation.
> > At the moment if the input parameter "is_coherent" is set to true
> > the allocation is not made using the CMA, which I think is not the
> > desired behaviour.
> > 
> > Signed-off-by: Lorenzo Nava <lorenx4@gmail.com>
> > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
> 
> If Russell doesn't have any objections, you can send the patch to
> his patch system. See here for more information:

I'm left wondering whether this patch is really want Lorenzo wants.
>From my reading of it, while this has the effect of allocating from
CMA for coherent devices, it's no different from the non-coherent
case, because by calling __alloc_from_contiguous(), we end up
remapping the allocated memory, removing the cacheability status
from the allocated pages.

This brings up an interesting point: presumably, it's been tested, and
people are happy with the performance it's giving, inspite of it not
returning cacheable memory... or maybe it hasn't been tested that much?

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-07-03  9:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-30 21:29 [PATCH v5] arm DMA: Fix allocation from CMA for coherent DMA Lorenzo Nava
2015-07-01 11:12 ` Catalin Marinas
2015-07-03  9:03   ` Russell King - ARM Linux [this message]
2015-07-03 10:26     ` Catalin Marinas
2015-07-03 11:23     ` Lorenzo Nava
2015-07-03 11:27     ` Lorenzo Nava
2015-07-06 19:49     ` Lorenzo Nava
2015-07-18 11:54     ` Lorenzo Nava
  -- strict thread matches above, loose matches on Subject: below --
2015-06-30 21:21 Lorenzo Nava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703090305.GR7557@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).