public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: antoine.tenart@free-electrons.com (Antoine Tenart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY
Date: Fri, 3 Jul 2015 11:18:31 +0200	[thread overview]
Message-ID: <20150703091831.GB5634@kwain> (raw)
In-Reply-To: <5594C65E.1030802@gmail.com>

Thomas,

On Thu, Jul 02, 2015 at 01:04:30AM -0400, Thomas Hebb wrote:
> We're not in a SATA PHY driver, so the of_match table shouldn't have
> "sata" in its name.

There is already a patch fixing this (which was sent last week):

https://lkml.org/lkml/2015/6/24/103

You can drop this one from the series.

Antoine

> 
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> Suggested-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
>  drivers/phy/phy-berlin-usb.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/phy/phy-berlin-usb.c b/drivers/phy/phy-berlin-usb.c
> index 335e06d..7143cd3 100644
> --- a/drivers/phy/phy-berlin-usb.c
> +++ b/drivers/phy/phy-berlin-usb.c
> @@ -152,7 +152,7 @@ static struct phy_ops phy_berlin_usb_ops = {
>  	.owner		= THIS_MODULE,
>  };
>  
> -static const struct of_device_id phy_berlin_sata_of_match[] = {
> +static const struct of_device_id phy_berlin_usb_of_match[] = {
>  	{
>  		.compatible = "marvell,berlin2-usb-phy",
>  		.data = &phy_berlin_pll_dividers[0],
> @@ -163,12 +163,12 @@ static const struct of_device_id phy_berlin_sata_of_match[] = {
>  	},
>  	{ },
>  };
> -MODULE_DEVICE_TABLE(of, phy_berlin_sata_of_match);
> +MODULE_DEVICE_TABLE(of, phy_berlin_usb_of_match);
>  
>  static int phy_berlin_usb_probe(struct platform_device *pdev)
>  {
>  	const struct of_device_id *match =
> -		of_match_device(phy_berlin_sata_of_match, &pdev->dev);
> +		of_match_device(phy_berlin_usb_of_match, &pdev->dev);
>  	struct phy_berlin_usb_priv *priv;
>  	struct resource *res;
>  	struct phy *phy;
> @@ -208,7 +208,7 @@ static struct platform_driver phy_berlin_usb_driver = {
>  	.driver	= {
>  		.name		= "phy-berlin-usb",
>  		.owner		= THIS_MODULE,
> -		.of_match_table	= phy_berlin_sata_of_match,
> +		.of_match_table	= phy_berlin_usb_of_match,
>  	 },
>  };
>  module_platform_driver(phy_berlin_usb_driver);
> -- 
> 2.4.4
> 

-- 
Antoine T?nart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-03  9:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02  5:04 [PATCH 4/4] phy: berlin-usb: rename table copied from SATA PHY Thomas Hebb
2015-07-03  9:18 ` Antoine Tenart [this message]
2015-07-03 14:34   ` Thomas Hebb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150703091831.GB5634@kwain \
    --to=antoine.tenart@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox