From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: crypto: marvell/CESA: Issues with non cache-line aligned buffers
Date: Fri, 3 Jul 2015 16:41:16 +0200 [thread overview]
Message-ID: <20150703144116.GK13481@lunn.ch> (raw)
In-Reply-To: <20150703131059.GX7557@n2100.arm.linux.org.uk>
> A few other things I notice when looking at this code:
>
> /* Not all platforms can gate the clock, so it is not
> an error if the clock does not exists. */
> cp->clk = clk_get(&pdev->dev, NULL);
> if (!IS_ERR(cp->clk))
> clk_prepare_enable(cp->clk);
>
> So, if clk_get() returns PTR_ERR(-EPROBE_DEFER) we treat that clock as
> missing? Is that really the behaviour you want there?
Hi Russell
I probably added that to the older driver and it got copied into the
newer one.
The clock it is using is added to the system using CLK_OF_DECLARE()
This results in an entry in the __clk_of_table table. That table is
walked in of_clk_init(), which is called by time_init() in
arch/arc/kernel/time.c, early in the boot.
If we get -EPROBE_DEFER, something is seriously wrong.
Andrew
next prev parent reply other threads:[~2015-07-03 14:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 9:43 crypto: marvell/CESA: Issues with non cache-line aligned buffers Boris Brezillon
2015-07-03 9:58 ` Russell King - ARM Linux
2015-07-03 14:23 ` Boris Brezillon
2015-07-03 13:10 ` Russell King - ARM Linux
2015-07-03 14:19 ` Boris Brezillon
2015-07-03 14:41 ` Andrew Lunn [this message]
2015-07-04 7:33 ` Herbert Xu
2015-07-04 7:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150703144116.GK13481@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).