linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] irqchip: dw-apb-ictl: add irq_set_affinity support
Date: Sat, 4 Jul 2015 09:26:23 +0100	[thread overview]
Message-ID: <20150704082623.GA7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1435987170-3962-3-git-send-email-jszhang@marvell.com>

On Sat, Jul 04, 2015 at 01:19:30PM +0800, Jisheng Zhang wrote:
> On Marvell Berlin SoCs, the cpu's local timer is shutdown when the cpu
> goes to a deep idle state, then the timer framework will be notified to
> use a broadcast timer instead. The broadcast timer uses dw-apb-ictl as
> interrupt chip, this patch adds irq_set_affinity support so that the
> going to deep idle state cpu can set the interrupt affinity of the
> broadcast interrupt to avoid unnecessary wakeups and IPIs.

NAK to this patch.

The real question is - if CPU0 is the CPU going offline, why is it
still receiving _any_ interrupts - all interrupts should be migrated
off it, including the chained interrupts.

Sounds like there's a bug in the migration code which needs further
investigation, rather than hacking around the problem by introducing
lots of driver code.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-07-04  8:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-04  5:19 [PATCH v2 0/2] irqchip: dw-apb-ictl: add irq_set_affinity support Jisheng Zhang
2015-07-04  5:19 ` [PATCH v2 1/2] irqchip: dw-apb-ictl: add private data structure Jisheng Zhang
2015-07-04  5:19 ` [PATCH v2 2/2] irqchip: dw-apb-ictl: add irq_set_affinity support Jisheng Zhang
2015-07-04  8:26   ` Russell King - ARM Linux [this message]
2015-07-04  8:50     ` Jisheng Zhang
2015-07-04  9:25       ` Russell King - ARM Linux
2015-07-04  9:35         ` Jisheng Zhang
2015-07-04  9:43           ` Jisheng Zhang
2015-07-04  9:53     ` Thomas Gleixner
2015-07-04 10:08       ` Russell King - ARM Linux
2015-07-04 10:33         ` Jisheng Zhang
2015-07-04 12:49         ` Thomas Gleixner
2015-07-04 13:16           ` Jisheng Zhang
2015-07-04 13:42             ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150704082623.GA7557@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).