linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ACPI / ARM64: add BAD_MADT_GICC_ENTRY() macro
Date: Tue, 7 Jul 2015 10:25:16 +0100	[thread overview]
Message-ID: <20150707092516.GC23879@arm.com> (raw)
In-Reply-To: <1436224608-27754-2-git-send-email-al.stone@linaro.org>

On Tue, Jul 07, 2015 at 12:16:47AM +0100, Al Stone wrote:
> From: Al Stone <al.stone@.linaro.org>
> 
> The BAD_MADT_ENTRY() macro is designed to work for all of the subtables
> of the MADT.  In the ACPI 5.1 version of the spec, the struct for the
> GICC subtable (struct acpi_madt_generic_interrupt) is 76 bytes long; in
> ACPI 6.0, the struct is 80 bytes long.  But, there is only one definition
> in ACPICA for this struct -- and that is the 6.0 version.  Hence, when
> BAD_MADT_ENTRY() compares the struct size to the length in the GICC
> subtable, it fails if 5.1 structs are in use, and there are systems in
> the wild that have them.
> 
> This patch adds the BAD_MADT_GICC_ENTRY() that checks the GICC subtable
> only, accounting for the difference in specification versions that are
> possible.  The BAD_MADT_ENTRY() will continue to work as is for all other
> MADT subtables.
> 
> This code is being added to an arm64 header file since that is currently
> the only architecture using the GICC subtable of the MADT.  As a GIC is
> specific to ARM, it is also unlikely the subtable will be used elsewhere.
> 
> Fixes: aeb823bbacc2 (ACPICA: ACPI 6.0: Add changes for FADT table.)
> Signed-off-by: Al Stone <al.stone@linaro.org>
> ---
>  arch/arm64/include/asm/acpi.h | 8 ++++++++
>  1 file changed, 8 insertions(+)

Not the nicest patch I've ever seen, but if it gets things working again:

  Acked-by: Will Deacon <will.deacon@arm.com>

Catalin, I assume you're picking these two up for 4.2?

Will

  reply	other threads:[~2015-07-07  9:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 23:16 [PATCH v4 0/2] Correct for ACPI 5.1->6.0 spec changes in MADT GICC entries Al Stone
2015-07-06 23:16 ` [PATCH v4 1/2] ACPI / ARM64: add BAD_MADT_GICC_ENTRY() macro Al Stone
2015-07-07  9:25   ` Will Deacon [this message]
2015-07-07 15:12     ` Al Stone
2015-07-06 23:16 ` [PATCH v4 2/2] ACPI / ARM64 : use the new BAD_MADT_GICC_ENTRY macro Al Stone
2015-07-06 23:20 ` [PATCH v4 0/2] Correct for ACPI 5.1->6.0 spec changes in MADT GICC entries Rafael J. Wysocki
2015-07-06 23:45   ` Al Stone
2015-07-07  6:40     ` Thomas Gleixner
2015-07-07 13:31   ` Catalin Marinas
2015-07-07 15:07     ` Al Stone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707092516.GC23879@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).