linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] arm: berlin: add cpu hotplug support
Date: Tue, 7 Jul 2015 15:38:14 +0800	[thread overview]
Message-ID: <20150707153814.72a8ec8f@xhacker> (raw)
In-Reply-To: <559B7FA2.4080005@gmail.com>

Dear Sebastian,

On Tue, 07 Jul 2015 09:28:34 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:

> On 07/07/2015 09:10 AM, Jisheng Zhang wrote:
> > These patches try to add cpu hotplug support for Marvell BG2, BG2Q SoCs.
> > These SoCs can't power off cpu independently, but we still want cpu hotplug
> > support for them. However, we need to address "CPU still sat on kernel text"
> > as pointed out by Mark Rutland[1]. We achieved this by putting the dying CPU
> > in WFI state after the coherency is disabled, then asserting the dying CPU
> > reset bit to put the CPU in reset state.
> 
> Jisheng,
> 
> thanks for the patches! Out of curiosity, did you measure overall SoC 
> power consumption with WFI and with reset respectively? I'd expect a
> slightly _higher_ power consumption while in reset depending on clock
> gating applied to the processor hardware.

Thank you for your review.
You are right. The cpu in reset state consumes a bit higher power than in WFI.
But seems we have no choice for BG2\BG2Q.

For newer Berlin SoCs than BG2Q, we support cpu power off and we'll walk through
the PSCI code path.

Thanks,
Jisheng

> 
> Sebastian
> 
> > patch1 use non-self-cleared control register to reset cpu. This is to prepare
> > for the next cpu hotplug commit.
> >
> > patch2 adds the cpu hotplug support finally.
> >
> >
> > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/342642.html
> >
> > Jisheng Zhang (2):
> >    arm: berlin: use non-self-cleared reset register to reset cpu
> >    arm: berlin: add CPU hotplug support
> >
> >   arch/arm/mach-berlin/platsmp.c | 29 ++++++++++++++++++++++++++++-
> >   1 file changed, 28 insertions(+), 1 deletion(-)
> >

      reply	other threads:[~2015-07-07  7:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07  7:10 [PATCH 0/2] arm: berlin: add cpu hotplug support Jisheng Zhang
2015-07-07  7:10 ` [PATCH 1/2] arm: berlin: use non-self-cleared reset register to reset cpu Jisheng Zhang
2015-07-07  7:10 ` [PATCH 2/2] arm: berlin: add CPU hotplug support Jisheng Zhang
2015-07-07  7:28 ` [PATCH 0/2] arm: berlin: add cpu " Sebastian Hesselbarth
2015-07-07  7:38   ` Jisheng Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150707153814.72a8ec8f@xhacker \
    --to=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).