From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: early fixmap support for earlycon
Date: Fri, 10 Jul 2015 12:25:22 +0100 [thread overview]
Message-ID: <20150710112522.GR7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20150606124800.GR7557@n2100.arm.linux.org.uk>
On Sat, Jun 06, 2015 at 01:48:00PM +0100, Russell King - ARM Linux wrote:
> On Sat, Jun 06, 2015 at 02:31:28PM +0200, Stefan Agner wrote:
> > @@ -1231,7 +1272,7 @@ static void __init devicemaps_init(const struct machine_desc *mdesc)
> >
> > early_trap_init(vectors);
> >
> > - for (addr = VMALLOC_START; addr; addr += PMD_SIZE)
> > + for (addr = VMALLOC_START; addr < FIXADDR_START; addr += PMD_SIZE)
> > pmd_clear(pmd_off_k(addr));
>
> You introduce a bug here - we no logner clear the very top entry of the
> page tables, which means it could contain anything - and means that the
> subsequent creation of the L2 table in early_pte_alloc() can fail.
You trimmed my reply hard, and seemingly ignored this; the v4 patch
contains exactly the same code here, and therefore continues to leave
the top of the page table uninitialised.
Not applying the v4 patch, sorry.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-07-10 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-06 12:31 [PATCH v3] ARM: early fixmap support for earlycon Stefan Agner
2015-06-06 12:48 ` Russell King - ARM Linux
2015-06-06 13:29 ` Stefan Agner
2015-06-06 15:29 ` Rob Herring
2015-06-08 14:05 ` Mark Salter
2015-07-10 11:25 ` Russell King - ARM Linux [this message]
2015-07-13 19:48 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710112522.GR7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).