[PATCH v2 08/10] arm64/debug: Add missing #include

Mark Rutland
2015-07-13T14:34:36Z

On Mon, Jul 13, 2015 at 02:25:55PM +0100, Dave P Martin wrote:
> <asm/debug-monitors.h> relies on <asm/ptrace.h>, but doesn't
> declare this dependency. This becomes a problem once
> debug-monitors.h starts getting included all over the place to get
> the BRK immedates.

I take it that's for struct pt_regs down in the ifndef __ASSEMBLY__
portion?

>
> This patch adds the missing #include.
>
> Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> ---
> arch/arm64/include/asm/debug-monitors.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/debug-monitors.h b/arch/arm64/include/asm/debug-monitors.h
> index 6a17fb8..b5715cb 100644
> --- a/arch/arm64/include/asm/debug-monitors.h
> +++ b/arch/arm64/include/asm/debug-monitors.h
> @@ -20,6 +20,7 @@
>
> #include <asm/esr.h>
> #include <asm/insn.h>
> +#include <asm/ptrace.h>

We're also missing <linux/types.h> (for struct list_head, u8, and u32),
and <linux/errno.h> (for ENODEV in the reinstall_suspended_bps stub).
Would you be able to fold those in?

With those:

Acked-by: Mark Rutland <mark.rutland@arm.com>

Mark.

>
> /* Low-level stepping controls. */
> #define DBG_MDSCR_SS (1 << 0)
> --
> 1.7.10.4
>