From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: omap2: restore OMAP4 barrier behaviour
Date: Thu, 16 Jul 2015 22:48:42 -0700 [thread overview]
Message-ID: <20150717054842.GS17550@atomide.com> (raw)
In-Reply-To: <20150716135413.GD7576@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [150716 06:56]:
> On Wed, Jul 15, 2015 at 11:48:54PM -0700, Tony Lindgren wrote:
> > Hi,
> >
> > * Russell King <rmk+kernel@arm.linux.org.uk> [150715 10:50]:
> > > Restore the OMAP4 barrier behaviour using the new implementation which
> > > allows multiplatform systems to hook into the mb() and wmb() ARM
> > > implementations to perform any necessary additional barrier maintanence.
> >
> > I'm getthing this with omap2plus_defconfig with the last patch
> > applied:
> >
> > arch/arm/mach-omap2/omap4-common.c: In function ?omap4_sram_init?:
> > arch/arm/mach-omap2/omap4-common.c:138:14: error: implicit declaration of function ?of_get_named_gen_pool? [-Werror=implicit-function-declaration]
> > sram_pool = of_get_named_gen_pool(np, "sram", 0);
> > ^
> > arch/arm/mach-omap2/omap4-common.c:138:12: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > sram_pool = of_get_named_gen_pool(np, "sram", 0);
> > ^
>
> I'd forgotten to merge in the merge window fixes for this... which have now
> been lost. This needs to become of_gen_pool_get() in 4.2-rc1 and later.
OK with that change looks good to me, so please feel free to
add for the whole series:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2015-07-17 5:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 17:46 [PATCH 0/4] Fix OMAP4 barrier support Russell King - ARM Linux
2015-07-15 17:47 ` [PATCH 1/4] ARM: move heavy barrier support out of line Russell King
2015-07-15 17:47 ` [PATCH 2/4] ARM: add soc memory barrier extension Russell King
2015-07-15 17:47 ` [PATCH 3/4] Revert "ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688" Russell King
2015-07-22 20:13 ` Woodruff, Richard
2015-07-15 17:47 ` [PATCH 4/4] ARM: omap2: restore OMAP4 barrier behaviour Russell King
2015-07-16 6:48 ` Tony Lindgren
2015-07-16 13:54 ` Russell King - ARM Linux
2015-07-17 5:48 ` Tony Lindgren [this message]
2015-07-27 21:23 ` Dan Murphy
2015-07-28 12:55 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717054842.GS17550@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).