From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings
Date: Fri, 17 Jul 2015 11:00:39 +0200 [thread overview]
Message-ID: <20150717090039.GC9331@earth> (raw)
In-Reply-To: <1437085227-28845-2-git-send-email-adam.yh.lee@gmail.com>
Hi,
To get a chance of this patch being considered for inclusion, you
should send this to the maintainers of the phy and iio framework.
There is a high chance, that none of them will see your mail.
On Thu, Jul 16, 2015 at 03:20:27PM -0700, Adam YH Lee wrote:
> MADC[3:6] reads incorrect values without these two following changes:
uhm MADC[3:6] are externally available analog inputs. Your
change will result in them being tied to the USB module.
> - enable the 3v1 bias regulator for ADC[3:6]
The regulator is not required for correct MADC functionality, but
for correct USB measureing. The regulator should not be requested
by the madc module, but by the usb module, which is connected to
the madc.
> - configure ADC[3:6] lines as input, not as USB
I don't think that should be done for all boards.
> [...]
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150717/e0810b09/attachment.sig>
next prev parent reply other threads:[~2015-07-17 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:20 [PATCH] Fix incomplete initialization of ADC[3:6] Adam YH Lee
2015-07-16 22:20 ` [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings Adam YH Lee
2015-07-17 9:00 ` Sebastian Reichel [this message]
2015-07-17 9:42 ` Peter Meerwald
2015-07-20 17:47 ` Adam Lee
2015-07-20 17:54 ` Jonathan Cameron
2015-07-20 18:23 ` Adam Lee
-- strict thread matches above, loose matches on Subject: below --
2015-07-20 18:14 [PATCH] Fix incomplete initialization of ADC[3:6]$ Adam YH Lee
2015-07-20 18:14 ` [PATCH] [TWL4030 MADC] Fix ADC[3:6] readings Adam YH Lee
2015-07-20 18:54 ` Peter Meerwald
2015-07-20 19:19 ` Adam Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717090039.GC9331@earth \
--to=sre@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).