From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs
Date: Sat, 18 Jul 2015 00:15:40 +0200 [thread overview]
Message-ID: <20150717221540.GK14024@cbox> (raw)
In-Reply-To: <1436378202-20224-6-git-send-email-marc.zyngier@arm.com>
On Wed, Jul 08, 2015 at 06:56:37PM +0100, Marc Zyngier wrote:
> We only set the irq_queued flag for level interrupts, meaning
> that "!vgic_irq_is_queued(vcpu, irq)" is a good enough predicate
> for all interrupts.
>
> This will allow us to inject edge HW interrupts, for which the
> state ACTIVE+PENDING is not allowed.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> virt/kvm/arm/vgic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/arm/vgic.c b/virt/kvm/arm/vgic.c
> index bc40137..5bd1695 100644
> --- a/virt/kvm/arm/vgic.c
> +++ b/virt/kvm/arm/vgic.c
> @@ -375,7 +375,7 @@ void vgic_cpu_irq_clear(struct kvm_vcpu *vcpu, int irq)
>
> static bool vgic_can_sample_irq(struct kvm_vcpu *vcpu, int irq)
> {
> - return vgic_irq_is_edge(vcpu, irq) || !vgic_irq_is_queued(vcpu, irq);
> + return !vgic_irq_is_queued(vcpu, irq);
> }
>
> /**
> --
> 2.1.4
>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2015-07-17 22:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 17:56 [PATCH v2 00/10] arm/arm64: KVM: Active interrupt state switching for shared devices Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 01/10] arm/arm64: KVM: Fix ordering of timer/GIC on guest entry Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 02/10] arm/arm64: KVM: Move vgic handling to a non-preemptible section Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 03/10] KVM: arm/arm64: vgic: Convert struct vgic_lr to use bitfields Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-21 18:02 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 04/10] KVM: arm/arm64: vgic: Allow HW irq to be encoded in LR Marc Zyngier
2015-07-17 19:50 ` Christoffer Dall
2015-07-21 16:38 ` Marc Zyngier
2015-08-04 12:14 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 05/10] KVM: arm/arm64: vgic: Relax vgic_can_sample_irq for edge IRQs Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall [this message]
2015-07-08 17:56 ` [PATCH v2 06/10] KVM: arm/arm64: vgic: Allow dynamic mapping of physical/virtual interrupts Marc Zyngier
2015-07-17 21:11 ` Christoffer Dall
2015-07-21 17:17 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 07/10] KVM: arm/arm64: vgic: Allow HW interrupts to be queued to a guest Marc Zyngier
2015-07-17 21:56 ` Christoffer Dall
2015-07-21 17:21 ` Marc Zyngier
2015-07-08 17:56 ` [PATCH v2 08/10] KVM: arm/arm64: vgic: Add vgic_{get, set}_phys_irq_active Marc Zyngier
2015-07-17 22:15 ` [PATCH v2 08/10] KVM: arm/arm64: vgic: Add vgic_{get,set}_phys_irq_active Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 09/10] KVM: arm/arm64: timer: Allow the timer to control the active state Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-08 17:56 ` [PATCH v2 10/10] KVM: arm/arm64: vgic: Allow non-shared device HW interrupts Marc Zyngier
2015-07-17 22:15 ` Christoffer Dall
2015-07-21 18:01 ` Marc Zyngier
2015-08-04 12:26 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717221540.GK14024@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).