next-20150722 build: 2 failures 75 warnings (next-20150722)

next-20150722 build: 2 failures 75 warnings (next-20150722)

[Mark Brown]

On Wed, Jul 22, 2015 at 03:30:56PM +0100, Build bot for Mark Brown wrote:

Today's linux-next fails to build an ARM allmodconfig due to:

> ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!

17c50b700c3b4 (memory: add ARM PL172 MultiPort Memory Controller
driver).  The symbol of_default_bus_match_table isn't exported by the OF
core code so can't be referenced from modules.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150722/82109b2c/attachment.sig>

next-20150722 build: 2 failures 75 warnings (next-20150722)

[Joachim Eastwood]

On 22 July 2015 at 20:43, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jul 22, 2015 at 03:30:56PM +0100, Build bot for Mark Brown wrote:
>
> Today's linux-next fails to build an ARM allmodconfig due to:
>
>> ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
>
> 17c50b700c3b4 (memory: add ARM PL172 MultiPort Memory Controller
> driver).  The symbol of_default_bus_match_table isn't exported by the OF
> core code so can't be referenced from modules.

Sorry about that. Seems like I didn't do a modular build after I
started to use "of_default_bus_match_table".
A quick fix would be to just replace "of_default_bus_match_table" with
NULL, but that means that child nodes that use "simple-bus" wouldn't
work. Since I don't have any nodes with "simple-bus" I'll send this
fix ASAP to Olof.

Grant/Rob: Would you be okay with a patch that exports
"of_default_bus_match_table"?
I think it would be useful for memory controllers to allow child nodes
that use "simple-bus" and "simple-mfd".

Note that "of_default_bus_match_table" is also used by
memory/omap-gpmc.c, but this drivers can only be built-in so it
doesn't face this problem.
memory/ti-aemif.c and memory/mvebu-devbus.c doesn't use
"of_default_bus_match_table", but again that means they can't have
child nodes with "simple-bus".


regards,
Joachim Eastwood

next-20150722 build: 2 failures 75 warnings (next-20150722)

[Rob Herring]

On Wed, Jul 22, 2015 at 4:26 PM, Joachim  Eastwood <manabian@gmail.com> wrote:
> On 22 July 2015 at 20:43, Mark Brown <broonie@kernel.org> wrote:
>> On Wed, Jul 22, 2015 at 03:30:56PM +0100, Build bot for Mark Brown wrote:
>>
>> Today's linux-next fails to build an ARM allmodconfig due to:
>>
>>> ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
>>
>> 17c50b700c3b4 (memory: add ARM PL172 MultiPort Memory Controller
>> driver).  The symbol of_default_bus_match_table isn't exported by the OF
>> core code so can't be referenced from modules.
>
> Sorry about that. Seems like I didn't do a modular build after I
> started to use "of_default_bus_match_table".
> A quick fix would be to just replace "of_default_bus_match_table" with
> NULL, but that means that child nodes that use "simple-bus" wouldn't
> work. Since I don't have any nodes with "simple-bus" I'll send this
> fix ASAP to Olof.

I think generally there is no reason to use NULL and most users can
safely pass of_default_bus_match_table. It would only matter if you
had children matching simple-*, but that should not be the case
typically.

> Grant/Rob: Would you be okay with a patch that exports
> "of_default_bus_match_table"?
> I think it would be useful for memory controllers to allow child nodes
> that use "simple-bus" and "simple-mfd".
>
> Note that "of_default_bus_match_table" is also used by
> memory/omap-gpmc.c, but this drivers can only be built-in so it
> doesn't face this problem.
> memory/ti-aemif.c and memory/mvebu-devbus.c doesn't use
> "of_default_bus_match_table", but again that means they can't have
> child nodes with "simple-bus".

I would prefer to see a wrapper function exported that internally
passes of_default_bus_match_table rather than exporting it. And then
clean-up all the callers including the ones passing NULL. Or if we
need to keep the NULL variant, perhaps 2 variants clearly named for
what they do: of_populate_children and of_populate_buses.

Rob

[PATCH] memory: pl172: fix modular build

[Joachim Eastwood]

Building pl172 as a module fails with:
> ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!

Because the symbol of_default_bus_match_table isn't exported by the OF
core code so can't be referenced from modules. Fix this by removing
the usage of of_default_bus_match_table for now. The side effect of
this is that child nodes can't use "simple-bus" or "simple-mfd".

Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Joachim Eastwood <manabian@gmail.com>
---

This should fix the allmod build failure introduces by the
pl172 driver that Mark encountered. After this fix the driver
should builds just fine as a module and there is no behavior
change when boot my devkit either since none of children under
pl172 uses "simple-bus/mfd" right now.

 drivers/memory/pl172.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/memory/pl172.c b/drivers/memory/pl172.c
index 3a8e57ee96f0..b2ef6072fbf4 100644
--- a/drivers/memory/pl172.c
+++ b/drivers/memory/pl172.c
@@ -255,8 +255,7 @@ static int pl172_probe(struct amba_device *adev, const struct amba_id *id)
 		if (ret)
 			continue;
 
-		of_platform_populate(child_np, of_default_bus_match_table,
-				     NULL, dev);
+		of_platform_populate(child_np, NULL, NULL, dev);
 	}
 
 	return 0;
-- 
1.8.0

[PATCH] memory: pl172: fix modular build

[Olof Johansson]

On Thu, Jul 23, 2015 at 12:10:37AM +0200, Joachim Eastwood wrote:
> Building pl172 as a module fails with:
> > ERROR: "of_default_bus_match_table" [drivers/memory/pl172.ko] undefined!
> 
> Because the symbol of_default_bus_match_table isn't exported by the OF
> core code so can't be referenced from modules. Fix this by removing
> the usage of of_default_bus_match_table for now. The side effect of
> this is that child nodes can't use "simple-bus" or "simple-mfd".
> 
> Reported-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
> ---
> 
> This should fix the allmod build failure introduces by the
> pl172 driver that Mark encountered. After this fix the driver
> should builds just fine as a module and there is no behavior
> change when boot my devkit either since none of children under
> pl172 uses "simple-bus/mfd" right now.

Thanks, applied.


-Olof