linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] thermal: consistently use int for temperatures
Date: Fri, 24 Jul 2015 08:29:48 +0200	[thread overview]
Message-ID: <20150724062948.GK18700@pengutronix.de> (raw)
In-Reply-To: <20150723120759.GA17690@amd>

On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote:
> On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
> > The thermal code uses int, long and unsigned long for temperatures
> > in different places.
> > 
> > Using an unsigned type limits the thermal framework to positive
> > temperatures without need. Also several drivers currently will report
> > temperatures near UINT_MAX for temperatures below 0?C. This will probably
> > immediately shut the machine down due to overtemperature if started below
> > 0?C.
> > 
> > 'long' is 64bit on several architectures. This is not needed since INT_MAX ?mC
> > is above the melting point of all known materials.
> 
> Can we do something like
> 
> typedef millicelsius_t int;
> 
> ...to document the units?

I am not very fond of typedefs and I am not sure this adds any value. I
could change it when more people ask for it, but I just sent the new
version without this.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2015-07-24  6:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-21  7:21 [PATCH v2] thermal: consistently use int for temperatures Sascha Hauer
2015-07-21 10:52 ` Punit Agrawal
2015-07-21 13:35   ` Zhang, Rui
2015-07-23 10:37     ` Sascha Hauer
2015-07-24  1:31       ` Zhang, Rui
2015-07-24  6:12         ` [PATCH v3] " Sascha Hauer
2015-07-23 12:07 ` [PATCH v2] " Pavel Machek
2015-07-24  6:29   ` Sascha Hauer [this message]
2015-07-24 13:59     ` Guenter Roeck
2015-07-24 22:11       ` Pavel Machek
2015-07-24 22:49         ` Guenter Roeck
2015-07-25  7:01           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150724062948.GK18700@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).