From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludovic.desroches@atmel.com (Ludovic Desroches) Date: Tue, 28 Jul 2015 15:12:53 +0200 Subject: [RESEND PATCH] pinctrl: at91: fix null pointer dereference In-Reply-To: References: <20150715133048.GD14886@odux.rfo.atmel.com> <1438069696-25303-1-git-send-email-ludovic.desroches@atmel.com> Message-ID: <20150728131253.GA4055@odux.rfo.atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 28, 2015 at 02:48:09PM +0200, Linus Walleij wrote: > On Tue, Jul 28, 2015 at 9:48 AM, Ludovic Desroches > wrote: > > > From: David Dueck > > > > Not all gpio banks are necessarily enabled, in the current code this can > > lead to null pointer dereferences. > > > > [ 51.130000] Unable to handle kernel NULL pointer dereference at virtual address 00000058 > (...) > > > > Signed-off-by: David Dueck > > Acked-by: Ludovic Desroches > > Acked-by: Alexandre Belloni > > CC: Nicolas Ferre > > CC: Boris Brezillon > > CC: linux-arm-kernel at lists.infradead.org > > CC: linux-kernel at vger.kernel.org > > --- > > > > This patch fixes a oops in the kernel because of a NULL pointer in a table. > > Having a NULL pointer in this table is the normal behavior if a PIO controller > > is not enabled. So this fix is not a quick and dirty hack, it's usual to skip > > an entry from a table if it is not filled. > > Fair enough, better too many checks than too few. > > Is this a regression to v4.2 that should go to stable or v4.3 material? Yes it is a regression from v4.0, it applies well on v4.0.9 Fixes: a0b957f306fa ("pinctrl: at91: allow to have disabled gpio bank") Cc: stable at vger.kernel.org # 4.0 Thanks Ludovic