linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: peter.chen@freescale.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] usb: chipidea: define stream mode disable for both roles
Date: Wed, 29 Jul 2015 12:41:29 +0800	[thread overview]
Message-ID: <20150729044128.GB27605@shlinux2> (raw)
In-Reply-To: <20150729051016.GB5502@kroah.com>

On Tue, Jul 28, 2015 at 10:10:16PM -0700, Greg KH wrote:
> On Wed, Jul 29, 2015 at 10:42:06AM +0800, Peter Chen wrote:
> > @@ -20,7 +20,6 @@ struct ci_hdrc_platform_data {
> >  	unsigned long	 flags;
> >  #define CI_HDRC_REGS_SHARED		BIT(0)
> >  #define CI_HDRC_SUPPORTS_RUNTIME_PM	BIT(2)
> > -#define CI_HDRC_DISABLE_STREAMING	BIT(3)
> 
> Why not just rename this one, now you have a "hole" in your bit field
> that people aren't going to know if they can use or not.
> 

I will change it, thanks.

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2015-07-29  4:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29  2:42 [PATCH 00/10] USB: chipidea misc patches Peter Chen
2015-07-29  2:42 ` [PATCH 01/10] usb: chipidea: udc: zero-length packet is only needed for TX Peter Chen
2015-07-29  2:42 ` [PATCH 02/10] usb: chipidea: define stream mode disable for both roles Peter Chen
2015-07-29  5:08   ` Greg KH
2015-07-29  4:40     ` Peter Chen
2015-07-29  5:10   ` Greg KH
2015-07-29  4:41     ` Peter Chen [this message]
2015-07-29  5:51   ` Sascha Hauer
2015-07-29  6:02     ` Sascha Hauer
2015-07-29  2:42 ` [PATCH 03/10] usb: chipidea: imx: add stream mode enable for device mode at imx6sl/imx6sx Peter Chen
2015-07-29  2:42 ` [PATCH 04/10] Doc: usb: ci-hdrc-usb2: add ahb-burst-config for binding doc Peter Chen
2015-07-29  2:42 ` [PATCH 05/10] ARM: imx6: set ahb-burst-config as 0 for USB Peter Chen
2015-07-29  2:42 ` [PATCH 06/10] usb: chipidea: add ahb burst configuration interface Peter Chen
2015-07-29  2:42 ` [PATCH 07/10] usb: chipidea: usbmisc_imx: add unburst setting for imx6 Peter Chen
2015-07-29  8:30   ` Lothar Waßmann
2015-07-29  7:57     ` Peter Chen
2015-07-29 10:19       ` Lothar Waßmann
2015-07-30  2:36         ` Peter Chen
2015-07-29  2:42 ` [PATCH 08/10] Doc: usb: ci-hdrc-usb2: add tx(rx)-burst-config-dword for binding doc Peter Chen
2015-07-29  2:42 ` [PATCH 09/10] ARM: imx6: change default burst size for USB Peter Chen
2015-07-29  2:42 ` [PATCH 10/10] usb: chipidea: add tx/rx burst size configuration interface Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729044128.GB27605@shlinux2 \
    --to=peter.chen@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).