linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: integrator: move framebuffers to driver
Date: Wed, 29 Jul 2015 20:38:47 +0100	[thread overview]
Message-ID: <20150729193846.GQ7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1438172831-11450-1-git-send-email-linus.walleij@linaro.org>

On Wed, Jul 29, 2015 at 02:27:11PM +0200, Linus Walleij wrote:
> Commit 11c32d7b6274cb0f554943d65bd4a126c4a86dcd
> "video: move Versatile CLCD helpers" already moved the
> CLCD mode setting helpers for Versatile and Integrator/CP
> to drivers/video/fbdev. Let's do the same for the IM-PD1
> add-on board, copy the missing displays into the database
> and simplify the code.

And thereby break the support.  The IM-PD1 CLCD can only access the memory
on the IM-PD1.  That's why the CLCD driver itself doesn't just allocate
the frame buffer using dma_alloc_writecombine().  Where the memory comes
from is platform specific.  In this case...

> -static int impd1fb_clcd_setup(struct clcd_fb *fb)
> -{
> -	unsigned long framebase = fb->dev->res.start + 0x01000000;
> -	unsigned long framesize = SZ_1M;

It's a chunk of SRAM offset by the specified value and of the specified
size above.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-07-29 19:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-29 12:27 [PATCH 1/2] ARM: integrator: move framebuffers to driver Linus Walleij
2015-07-29 19:38 ` Russell King - ARM Linux [this message]
2015-08-03  7:30   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150729193846.GQ7557@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).