From: leo.yan@linaro.org (Leo Yan)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver
Date: Tue, 4 Aug 2015 17:00:59 +0800 [thread overview]
Message-ID: <20150804090059.GB27609@leoy-linaro> (raw)
In-Reply-To: <20150804084930.GA27609@leoy-linaro>
Hi Paul,
On Tue, Aug 04, 2015 at 04:49:30PM +0800, Leo Yan wrote:
> On Tue, Aug 04, 2015 at 10:30:24AM +0200, Paul Bolle wrote:
> > (This RFC was part of this mornings catch of my crude mail filter. So,
> > for what it's worth, what follows are a few random comments for the few
> > things I'm able to spot.)
[...]
> > > +static int __init hi6220_mbox_init(void)
> > > +{
> > > + return platform_driver_register(&hi6220_mbox_driver);
> > > +}
> > > +module_init(hi6220_mbox_init);
> > > +
> > > +static void __exit hi6220_mbox_exit(void)
> > > +{
> > > + platform_driver_unregister(&hi6220_mbox_driver);
> > > +}
> > > +module_exit(hi6220_mbox_exit);
> >
> > This could be flattened into one line:
> > module_platform_driver(hi6220_mbox_driver);
Need clarify one thing: will modify to use core_initcall() for driver's
initialization; due another clock driver depends on this mailbox driver,
so mailbox init firstly with core_initcall() and use subsys_initcall()
for clock driver.
Thanks,
Leo Yan
next prev parent reply other threads:[~2015-08-04 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 1:13 [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Leo Yan
2015-08-03 1:13 ` [RFC PATCH 1/3] dt-bindings: mailbox: Document Hisilicon " Leo Yan
2015-08-03 1:13 ` [RFC PATCH 2/3] mailbox: Hisilicon: add " Leo Yan
2015-08-04 8:30 ` Paul Bolle
2015-08-04 8:49 ` Leo Yan
2015-08-04 9:00 ` Leo Yan [this message]
2015-08-04 9:17 ` Paul Bolle
2015-08-04 9:56 ` Leo Yan
2015-08-03 1:13 ` [RFC PATCH 3/3] arm64: dts: add Hi6220 mailbox node Leo Yan
2015-08-05 10:52 ` [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Jassi Brar
2015-08-05 23:17 ` Leo Yan
2015-08-10 7:02 ` Jassi Brar
2015-08-10 8:52 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804090059.GB27609@leoy-linaro \
--to=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox