From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: IRQ setup on multicore systems (routing, balancing, etc)
Date: Thu, 6 Aug 2015 21:38:16 +0100 [thread overview]
Message-ID: <20150806203816.GG7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <55C387F6.8090708@free.fr>
On Thu, Aug 06, 2015 at 06:14:46PM +0200, Mason wrote:
> It doesn't help that the port I'm working on doesn't follow
> "established guidelines". In this case, interrupt routing is
> hard-coded in the platform code:
>
> static inline void tangox_enable(struct irq_data *data)
> {
> int bit = data->irq - IRQ_CONTROLLER_IRQ_BASE;
> #ifdef ENABLE_INTERRUPT_ON_CPU1
> if(route_interrupt_to_cpu1(bit))
> tangox_fiq_enable(bit);
> else
> #endif
> tangox_irq_enable(bit);
> }
>
> (tangox_enable is called in the .irq_startup struct irq_chip callback.)
>
> Throw weird naming in the mix (I thought FIQ was reserved for
> the secure world, and my Linux runs in non-secure) and my
> confusion level is up to 11.
Looking at the above code, I must say that it looks like the code is on
some kind of drugs. The code implies that FIQs are routed to CPU1, which
is obviously a totally insane. I think I'd be as confused as you over
that.
Are you basing your idea that certain interrupts need to be routed to a
certain CPU on this code, or on practical experience? It may be better
to experiment with the hardware to find out what's possible rather than
rely on hacky undocumented code such as the above.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2015-08-06 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 13:41 IRQ setup on multicore systems (routing, balancing, etc) Mason
2015-08-05 8:40 ` Mason
2015-08-06 15:17 ` Mason
2015-08-06 15:26 ` Russell King - ARM Linux
2015-08-06 16:14 ` Mason
2015-08-06 20:38 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806203816.GG7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).