From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Mon, 10 Aug 2015 12:42:24 +0100 Subject: [PATCH] mfd: mt6397: Implement wake handler and suspend/resume for mt6397-core.c In-Reply-To: <1438268846-22451-1-git-send-email-henryc.chen@mediatek.com> References: <1438268846-22451-1-git-send-email-henryc.chen@mediatek.com> Message-ID: <20150810114224.GD3249@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org No need to mention the filename in the subject line. You already mentioned which driver is effected by the change. > Register mt6393_irq as wake up source to pinctrl by flag "IRQF_NO_SUSPEND". > Implement .irq_set_wake() function of pmic to keep who is wakeup source, > and enable irq on .suspend()and restore irq on .resume(). > > Signed-off-by: Henry Chen > --- > drivers/mfd/mt6397-core.c | 49 ++++++++++++++++++++++++++++++++++++++++- > include/linux/mfd/mt6397/core.h | 1 + > 2 files changed, 49 insertions(+), 1 deletion(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 03929a6..aebdee5 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c [...] > @@ -142,6 +161,7 @@ static int mt6397_irq_domain_map(struct irq_domain *d, unsigned int irq, > irq_set_chip_data(irq, mt6397); > irq_set_chip_and_handler(irq, &mt6397_irq_chip, handle_level_irq); > irq_set_nested_thread(irq, 1); > + Remainder of the patch looks okay, but this irrelevant change, which has nothing to do with the remainder of the patch will cause issues if I attempt to apply it. Please remove and re-submit. [...] -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog